After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678763 - [playsink] Changing the deinterlace flag during playback breaks colorbalance/xoverlay interfaces
[playsink] Changing the deinterlace flag during playback breaks colorbalance/...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.36
Other Windows
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-25 08:50 UTC by Xavi Artigas
Modified: 2012-06-26 09:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Modified Playback Tutorial 5 from the GStreamer SDK (5.05 KB, text/plain)
2012-06-25 08:50 UTC, Xavi Artigas 		Details

Description Xavi Artigas 2012-06-25 08:50:58 UTC 
Created attachment 217173 [details]
Modified Playback Tutorial 5 from the GStreamer SDK

The attached code demonstrates color balance and deinterlacing.
Color balance works as expected, with changes taking effect immediately.
However, when the deinterlace flag is changed (which does not have any visual impact because the pipeline is in the PLAYING state, see related bug 678762) color balance settings no longer take immediate effect.
The pipeline needs to be brought to READY and then back to PLAYING for the changes to the color balance to take effect (only after the deinterlace flag has been modified: it works fine initially)

Only observed on Windows with D3DVideoSink. Works fine on Linux with XImageSink.
The code contains the URL of media that can be used for testing.
Comment 1 Sebastian Dröge (slomo) 2012-06-25 13:16:24 UTC 
commit 823ccf2d174f06f8413156ac8cf7a5cd360531e3
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Jun 25 15:14:21 2012 +0200

    playsink: Only remove the xoverlay/colorbalance elements when necessary
    
    They are not added again by every code path, e.g. when switching
    only the deinterlace flag and are missing then.
    
    Fixes bug #678763.