GNOME Bugzilla – Bug 678668
paused vs off
Last modified: 2013-01-09 13:26:25 UTC
We should probably not show the printer status as 'Paused' and at the same time use on/off terminology in the switch. The other problem I found is that the on/off switch currently just controls what s-c-printer alls 'enabled'. There is no way to make the printer stop accepting jobs in the printer panel. s-c-printer has separate checkboxes for these: 'enabled' and 'accepting jobs'. I think if we only want a single switch, we probably want to make it control both of these, so that a printer that has been switched 'off' does not accept jobs anymore. Jon, opinions on this ?
Yeah paused seems weird. Proposal seems reasonable to me. I'm still not sure why I'd turn a printer off anyway. But I suppose it can be turned off by an admin and locked down? In that case definitely don't want to queue jobs.
I'm thinking about how to implement this. I would use this: accepting_jobs && enabled == ON pressing ON / OFF button would "enable printer, accept jobs / disable printer, reject jobs" Hopefully users won't be confused by the state when !accepting_jobs && enabled (== OFF) because the printer is enabled but they see that it is OFF (I would add state "Not accepting jobs" for this case). For the text of the state "Stopped" is probably the best solution. What do you think about this? (This is a tiny change but I would like to know whether you agree with this.)
Created attachment 220871 [details] [review] printers: Control acceptance of jobs with enable switch This patch implements the mechanism mentioned in the previous comment.
I've removed the now unused "sensitive" variable as well. Attachment 220871 [details] pushed as 3482dd1 - printers: Control acceptance of jobs with enable switch