After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678591 - Port policy client to WebKit2
Port policy client to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-06-22 06:11 UTC by Carlos Garcia Campos
Modified: 2012-06-25 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (7.66 KB, patch)
2012-06-22 06:11 UTC, Carlos Garcia Campos 		reviewed Details | Review
Updated patch (8.14 KB, patch)
2012-06-25 09:06 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-06-22 06:11:45 UTC 
Created attachment 216989 [details] [review]
Patch

Add policy client implementation using WebKit2 API.
Comment 1 Xan Lopez 2012-06-24 21:29:47 UTC 
Review of attachment 216989 [details] [review]:

::: embed/ephy-web-view.c
@@ +1729,3 @@
+   * since it looks unused, for now the default wk handler
+   * should do the right thing
+   */

This signal is used by extensions who wish to handle downloads. So please add it back here, since it's just a matter of copy&pasting the code.
Comment 2 Carlos Garcia Campos 2012-06-25 09:06:34 UTC 
Created attachment 217176 [details] [review]
Updated patch
Comment 3 Xan Lopez 2012-06-25 09:31:21 UTC 
Review of attachment 217176 [details] [review]:

OK.