After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678569 - Theming broken for selectionbar and notification bar
Theming broken for selectionbar and notification bar
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-21 18:39 UTC by Alexander Larsson
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Break out code to helper draw_as_css_box (2.27 KB, patch)
2012-06-21 18:40 UTC, Alexander Larsson 		committed Details | Review
Fix up themeing of selection bar (3.63 KB, patch)
2012-06-21 18:40 UTC, Alexander Larsson 		none Details | Review
Fix theming for notification bar (2.07 KB, patch)
2012-06-21 18:40 UTC, Alexander Larsson 		committed Details | Review
Fix up themeing of selection bar (3.83 KB, patch)
2012-06-25 13:02 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2012-06-21 18:39:32 UTC 
Css patches coming right up.
Comment 1 Alexander Larsson 2012-06-21 18:40:11 UTC 
Created attachment 216951 [details] [review]
Break out code to helper draw_as_css_box
Comment 2 Alexander Larsson 2012-06-21 18:40:14 UTC 
Created attachment 216952 [details] [review]
Fix up themeing of selection bar

This makes the selection bar render properly.
It was not getting a transparent background for the rounded
corners, and it was having weird sizing errors when the favorite
button was on and you hovered the remove button.
Comment 3 Alexander Larsson 2012-06-21 18:40:17 UTC 
Created attachment 216953 [details] [review]
Fix theming for notification bar
Comment 4 Zeeshan Ali 2012-06-21 19:48:52 UTC 
Review of attachment 216951 [details] [review]:

ACK
Comment 5 Alexander Larsson 2012-06-21 20:04:00 UTC 
Comment on attachment 216951 [details] [review]
Break out code to helper draw_as_css_box

Attachment 216951 [details] pushed as 7f4674d - Break out code to helper draw_as_css_box
Comment 6 Alexander Larsson 2012-06-25 13:02:51 UTC 
Created attachment 217193 [details] [review]
Fix up themeing of selection bar

This makes the selection bar render properly.
It was not getting a transparent background for the rounded
corners, and it was having weird sizing errors when the favorite
button was on and you hovered the remove button.
Comment 7 Alexander Larsson 2012-06-25 13:04:40 UTC 
Attached a new fixed up selection bar patch that works with the latest gtk/adwaita.
Comment 8 Zeeshan Ali 2012-06-25 14:51:55 UTC 
Review of attachment 216953 [details] [review]:

Fixes the style for me.
Comment 9 Zeeshan Ali 2012-06-25 14:52:25 UTC 
Review of attachment 217193 [details] [review]:

Same here.
Comment 10 Alexander Larsson 2012-06-25 15:10:20 UTC 
Attachment 216953 [details] pushed as 325f8c2 - Fix theming for notification bar
Attachment 217193 [details] pushed as 92459c0 - Fix up themeing of selection bar