After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678519 - grl_media_source_get_media_from_uri not implemented for tracker media source plugin
grl_media_source_get_media_from_uri not implemented for tracker media source ...
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
0.1.x
Other Linux
: Normal enhancement
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-21 05:31 UTC by Mateu Batle
Modified: 2014-08-08 23:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker: Add test_media_from_uri (4.71 KB, patch)
2014-07-30 19:51 UTC, Juan A. Suarez Romero 		committed Details | Review
tracker: Add media_from_uri operation (6.06 KB, patch)
2014-07-30 19:51 UTC, Juan A. Suarez Romero 		committed Details | Review

Description Mateu Batle 2012-06-21 05:31:46 UTC 
This is an important feature for Grilo Tracker plugin. It allows applications to obtain a Grilo media source object from a specific URI, and in this way access to its metadata.

Please consider adding it to the 0.1.x version in next release.
Comment 1 Mateu Batle 2012-08-09 22:15:13 UTC 
any update on this ?
Comment 2 Juan A. Suarez Romero 2012-08-10 07:17:40 UTC 
Didn't have time to work on it.

Patches are welcomed :)
Comment 3 Alvaro Soliverez 2014-04-18 11:14:16 UTC 
Any update on this?
Comment 4 Juan A. Suarez Romero 2014-04-22 07:08:33 UTC 
Alvaro, sorry, didn't have time to work on it yet. A patch is more than welcomed.
Comment 5 Juan A. Suarez Romero 2014-07-30 19:51:06 UTC 
Created attachment 282103 [details] [review]
tracker: Add test_media_from_uri

Given an URL, tests if Tracker source can create a media out of it.
Comment 6 Juan A. Suarez Romero 2014-07-30 19:51:11 UTC 
Created attachment 282104 [details] [review]
tracker: Add media_from_uri operation

Given an URL, re-constructs the GrlMedia corresponding to that URL.
Comment 7 Bastien Nocera 2014-07-30 22:51:11 UTC 
Looks like quite a bit of duplicated code between the 2 patches, any chance to reduce the duplication?
Comment 8 Juan A. Suarez Romero 2014-07-31 06:51:07 UTC 
Do you mean mainly in the requests definitions?
Comment 9 Juan A. Suarez Romero 2014-07-31 17:48:09 UTC 
Also, I've kept the duplication for consistency with the remaining code.

Probably we should do a global effort in Tracker source to reduce the duplication.
Comment 10 Bastien Nocera 2014-08-08 08:42:02 UTC 
(In reply to comment #9)
> Also, I've kept the duplication for consistency with the remaining code.
> 
> Probably we should do a global effort in Tracker source to reduce the
> duplication.

grl_tracker_source_test_media_from_uri() and grl_tracker_source_get_media_from_uri() do pretty much the same thing. Though one is sync, the other async. Probably not worth doing code de-duplication now as you mentioned.

Both patches look fine to me.
Comment 11 Juan A. Suarez Romero 2014-08-08 23:56:32 UTC 
Attachment 282103 [details] pushed as f60d9e7 - tracker: Add test_media_from_uri
Attachment 282104 [details] pushed as c705e77 - tracker: Add media_from_uri operation