After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678502 - Util: fix error handling in trySpawn
Util: fix error handling in trySpawn
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-20 20:47 UTC by Giovanni Campagna
Modified: 2012-06-21 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Util: fix error handling in trySpawn (2.07 KB, patch)
2012-06-20 20:47 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-06-20 20:47:05 UTC 
Error rewriting code used an old version of the gjs GError support,
and set a readonly .message property.
Comment 1 Giovanni Campagna 2012-06-20 20:47:08 UTC 
Created attachment 216874 [details] [review]
Util: fix error handling in trySpawn
Comment 2 Colin Walters 2012-06-20 21:56:36 UTC 
Review of attachment 216874 [details] [review]:

I'd make the commit message "Update trySpawn to new gjs GError mapping"

The old code was really a workaround relying on the implementation details of how gjs_invoke_c_function() dealt with GErrors.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-20 22:01:00 UTC 
I don't even know why we're doing the special mangling. We should probably just take it out.
Comment 4 Giovanni Campagna 2012-06-21 16:29:42 UTC 
I don't why the mangling is there either, but for now let's
restore what we were doing before the gjs GError merge.