After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678416 - workspace: Minor clean-ups
workspace: Minor clean-ups
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-19 16:24 UTC by Florian Müllner
Modified: 2012-06-20 00:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workspace: Remove unused method (1.17 KB, patch)
2012-06-19 16:24 UTC, Florian Müllner
committed Details | Review
workspace: Minor cleanup (1.61 KB, patch)
2012-06-19 16:25 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-06-19 16:24:50 UTC
See patches.
Comment 1 Florian Müllner 2012-06-19 16:24:59 UTC
Created attachment 216759 [details] [review]
workspace: Remove unused method

This one hasn't been used for quite a while now ...
Comment 2 Florian Müllner 2012-06-19 16:25:03 UTC
Created attachment 216760 [details] [review]
workspace: Minor cleanup

_hideAllOverlays() has only been used in a single place for quite
some time now, so move its code into the caller and save a loop.
Comment 3 Florian Müllner 2012-06-19 17:14:44 UTC
Approved on IRC, pushing ...

Attachment 216759 [details] pushed as 2404d29 - workspace: Remove unused method
Attachment 216760 [details] pushed as 0804cef - workspace: Minor cleanup