After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678406 - [PATCH] fix mem leaks
[PATCH] fix mem leaks
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-19 13:44 UTC by Pavel Vasin
Modified: 2012-06-24 04:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-widget: fix GList leak (1.14 KB, patch)
2012-06-19 13:44 UTC, Pavel Vasin 		needs-work Details | Review
pokit-agent: fix memory leak (853 bytes, patch)
2012-06-19 13:44 UTC, Pavel Vasin 		committed Details | Review
st-widget: fix GList leak (1.10 KB, patch)
2012-06-19 15:11 UTC, Pavel Vasin 		reviewed Details | Review
st-widget: fix GList leak (1.26 KB, patch)
2012-06-23 08:35 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2012-06-19 13:44:02 UTC 
Created attachment 216748 [details] [review]
st-widget: fix GList leak

.
Comment 1 Pavel Vasin 2012-06-19 13:44:42 UTC 
Created attachment 216749 [details] [review]
pokit-agent: fix memory leak
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-06-19 14:14:58 UTC 
Review of attachment 216748 [details] [review]:

This should really be using the linked list children iterator API instead. See the rest of the file for details.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-19 14:15:59 UTC 
Review of attachment 216749 [details] [review]:

Sure.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-06-19 14:16:11 UTC 
Review of attachment 216749 [details] [review]:

er, Sure.
Comment 5 Pavel Vasin 2012-06-19 15:11:26 UTC 
Created attachment 216755 [details] [review]
st-widget: fix GList leak
Comment 6 drago01 2012-06-22 20:50:32 UTC 
Review of attachment 216755 [details] [review]:

Good catch.

Should probably add something to the body of the commit message as it isn't really obvious why this is a leak (i.e that clutter_actor_get_children returns a newly allocated list and we where not freeing it.
Comment 7 Pavel Vasin 2012-06-23 08:35:21 UTC 
Created attachment 217061 [details] [review]
st-widget: fix GList leak

updated commit message
Comment 8 drago01 2012-06-23 17:27:23 UTC 
Review of attachment 217061 [details] [review]:

Looks good.
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-06-24 04:26:23 UTC 
Attachment 216749 [details] pushed as 4e4092f - pokit-agent: fix memory leak
Attachment 217061 [details] pushed as 556d5d1 - st-widget: fix GList leak