GNOME Bugzilla – Bug 678337
boxpointer: Fully honor 'animate' parameter on show/hide
Last modified: 2012-07-06 14:17:08 UTC
I'm not sure if binding 'animate' only to the boxpointer movement and still doing the animated fade was done on purpose but I'd really like to change this for the input method popups which can't have any lag really.
Created attachment 216690 [details] [review] boxpointer: Fully honor 'animate' parameter on show/hide
Review of attachment 216690 [details] [review]: (In reply to comment #0) > I'm not sure if binding 'animate' only to the boxpointer movement and > still doing the animated fade was done on purpose Yes. The designers are very explicit of not wanting abrupt "transitions" in the interface. In this case, the property is working as intended - the slide in is a nice transition when initially popping up the menu, but way too much when done for every menu when moving along the menubar. It is admittedly badly named of course. > but I'd really like to change this for the input method popups which > can't have any lag really. If you can get buy-in from designers for this, you should not change the animation of the existing menus though. I'd say make the "animate" property a flag (POPUP_ANIMATION_NONE, POPUP_ANIMATION_SLIDE, POPUP_ANIMATION_FADE or something) and introduce some API to allow turning all animations off in the one case you need to.
Created attachment 217228 [details] [review] boxpointer: Change 'animate' parameter on show/hide to a bitmask -- Something like this?
Review of attachment 217228 [details] [review]: Yeah, that's going in the direction I had in mind. ::: js/ui/boxpointer.js @@ +104,3 @@ onComplete(); }), + time: fade ? POPUP_ANIMATION_TIME : 0 }); This is wrong - if SLIDE is set, you will want an animation time > 0 regardless of whether FADE is set or not.
Created attachment 217334 [details] [review] boxpointer: Change 'animate' parameter on show/hide to a bitmask -- Thanks for catching that. Should work for all combinations now.
Review of attachment 217334 [details] [review]: Thanks, looks good now
should get this landed then, I guess ?
Attachment 217334 [details] pushed as cf6f149 - boxpointer: Change 'animate' parameter on show/hide to a bitmask