After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678174 - UI alignment fixes
UI alignment fixes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
: 678160 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-15 15:08 UTC by Cosimo Cecchi
Modified: 2012-06-20 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
online-accounts: fix alignment with closing button (2.84 KB, patch)
2012-06-15 15:08 UTC, Cosimo Cecchi
committed Details | Review
online-accounts: make "Add Account" label bigger and centered (1.43 KB, patch)
2012-06-15 15:08 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2012-06-15 15:08:15 UTC
The scrolled window is not left-aligned with the close button, and the "Add account" label should be consistent with the User Accounts panel
Comment 1 Cosimo Cecchi 2012-06-15 15:08:21 UTC
Created attachment 216525 [details] [review]
online-accounts: fix alignment with closing button
Comment 2 Cosimo Cecchi 2012-06-15 15:08:30 UTC
Created attachment 216526 [details] [review]
online-accounts: make "Add Account" label bigger and centered

So it's consistent with the User Accounts panel.
Comment 3 Bastien Nocera 2012-06-15 15:21:37 UTC
Review of attachment 216525 [details] [review]:

::: panels/online-accounts/cc-online-accounts-add-account-dialog.c
@@ +254,3 @@
   vbox = gtk_dialog_get_content_area (GTK_DIALOG (add_account));
+  grid = gtk_grid_new ();
+  gtk_container_set_border_width (GTK_CONTAINER (grid), 5);

Why 5?
Comment 4 Bastien Nocera 2012-06-15 15:22:08 UTC
Review of attachment 216526 [details] [review]:

Looks good.
Comment 5 Cosimo Cecchi 2012-06-15 15:37:05 UTC
Attachment 216525 [details] pushed as b40c1fb - online-accounts: fix alignment with closing button
Attachment 216526 [details] pushed as a1abae0 - online-accounts: make "Add Account" label bigger and centered
Comment 6 Debarshi Ray 2012-06-20 17:18:44 UTC
*** Bug 678160 has been marked as a duplicate of this bug. ***