After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677982 - "Connecting" icon shown when network is offline
"Connecting" icon shown when network is offline
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-12 22:10 UTC by Cosimo Cecchi
Modified: 2012-08-20 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (171.66 KB, image/png)
2012-06-12 22:11 UTC, Cosimo Cecchi
  Details
userMenu: Delay restoring presence until the network comes up (3.03 KB, patch)
2012-06-13 14:29 UTC, Florian Müllner
committed Details | Review
userMenu: Make presence chooser insensitive when offline (1.54 KB, patch)
2012-06-13 14:29 UTC, Florian Müllner
committed Details | Review

Description Cosimo Cecchi 2012-06-12 22:10:50 UTC
If the network is offline, we shouldn't show the "..." bubble icon in the status menu. See attached screenshot
Comment 1 Cosimo Cecchi 2012-06-12 22:11:25 UTC
Created attachment 216237 [details]
screenshot

Note how the network is offline, but the icon shows the connecting state.
Comment 2 Florian Müllner 2012-06-13 14:29:16 UTC
Created attachment 216288 [details] [review]
userMenu: Delay restoring presence until the network comes up

Trying to connect to IM servers while offline is pointless, in
particular now that we added a progress indication which makes
the connection attempt very visible.
To fix, wait for the network to become available until restoring
a previous IM presence.
Comment 3 Florian Müllner 2012-06-13 14:29:21 UTC
Created attachment 216289 [details] [review]
userMenu: Make presence chooser insensitive when offline

Setting an IM presence only makes sense when connected to the
network, reflect this by making the presence chooser insensitive
when no network is available.
Comment 4 Guillaume Desmottes 2012-06-13 14:45:05 UTC
Note that if telepathy-mission-control has been built with NM support, it won't try to actually connect the accounts until the network is up.
Comment 5 Florian Müllner 2012-06-14 12:56:10 UTC
Is this something we can test for? In any case, we'll still want to monitor the network ourselves, to update the sensitivity of the presence chooser.
Comment 6 Cosimo Cecchi 2012-06-14 13:28:47 UTC
(In reply to comment #4)
> Note that if telepathy-mission-control has been built with NM support, it won't
> try to actually connect the accounts until the network is up.

FWIW the telepathy-mission-control I was using (stock Fedora rawhide one) was built with NM support enabled.
Comment 7 Florian Müllner 2012-06-14 14:21:00 UTC
(In reply to comment #6)
> FWIW the telepathy-mission-control I was using (stock Fedora rawhide one) was
> built with NM support enabled.

Interesting. We show the "pending" icon if at least one telepathy account has the state CONNECTING, so it looks like that state is set regardless of whether mission-control is actually trying to connect or not.
Comment 8 Florian Müllner 2012-07-03 22:28:47 UTC
Ping?
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-07-03 23:09:25 UTC
(In reply to comment #8)
> Ping?

About the patch, or about a Telepathy developer's response to the last comment?
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-07-03 23:13:04 UTC
Review of attachment 216289 [details] [review]:

I'm not sure this makes sense. I'd like to be able to set myself to another status for when the network comes back up.
Comment 11 Guillaume Desmottes 2012-07-04 08:11:40 UTC
(In reply to comment #5)
> Is this something we can test for? In any case, we'll still want to monitor the
> network ourselves, to update the sensitivity of the presence chooser.

Nope, but that's something I'd like to have as well; see https://bugs.freedesktop.org/show_bug.cgi?id=45126

(In reply to comment #7)
> (In reply to comment #6)
> > FWIW the telepathy-mission-control I was using (stock Fedora rawhide one) was
> > built with NM support enabled.
> 
> Interesting. We show the "pending" icon if at least one telepathy account has
> the state CONNECTING, so it looks like that state is set regardless of whether
> mission-control is actually trying to connect or not.

I don't think we can have a connection in the CONNECTING state without MC requesting it to connect (Account.RequestedPresence being not offline).
Comment 12 Florian Müllner 2012-08-15 10:37:40 UTC
(In reply to comment #10)
> I'm not sure this makes sense. I'd like to be able to set myself to another
> status for when the network comes back up.

For what it's worth, I've spoken with the designers and they agree that it does make sense :-)

So I'd still like to get this in ...
Comment 13 Jasper St. Pierre (not reading bugmail) 2012-08-20 20:27:51 UTC
Review of attachment 216289 [details] [review]:

Sure.
Comment 14 Florian Müllner 2012-08-20 22:11:06 UTC
Attachment 216288 [details] pushed as 0f065eb - userMenu: Delay restoring presence until the network comes up
Attachment 216289 [details] pushed as cd43c49 - userMenu: Make presence chooser insensitive when offline