GNOME Bugzilla – Bug 677980
shell: Handle non-existant panels more gracefully
Last modified: 2012-06-20 18:17:49 UTC
Doing: $ gnome-control-center $ gnome-control-center non-existant will print a bunch of warnings. Fix those.
Created attachment 216236 [details] [review] shell: Handle non-existant panels more gracefully If we're at the overview screen and try to launch a non-existant panel, we shouldn't remove the scroll view.
Review of attachment 216236 [details] [review]: ::: shell/gnome-control-center.c @@ -946,3 @@ - priv->scrolled_window, - TRUE); - g_warning ("Could not find settings panel \"%s\"", start_id); That warning has a purpose.
Created attachment 216359 [details] [review] shell: Handle non-existant panels more gracefully If we're at the overview screen and try to launch a non-existant panel, we shouldn't remove the scroll view. Whoops, I removed it accidentally.
(In reply to comment #3) > Created an attachment (id=216359) [details] [review] > shell: Handle non-existant panels more gracefully Patch itself looks fine. > If we're at the overview screen and try to launch a non-existant panel, > we shouldn't remove the scroll view. I get: ** (gnome-control-center:9271): CRITICAL **: cc_notebook_remove_page: assertion `GTK_IS_WIDGET (widget)' failed And the overview is still there. Granted it's not nice, but it's not as critical as removing the scroll view.
The cc-notebook doesn't seem to handle it too well. If I then click on something, it doesn't do the fancy animation.
Attachment 216359 [details] pushed as fd3afa8 - shell: Handle non-existant panels more gracefully