After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677848 - schemas: Add picture keys for screensaver
schemas: Add picture keys for screensaver
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on: 690378
Blocks: 688210
 
 
Reported: 2012-06-11 11:02 UTC by Bastien Nocera
Modified: 2013-02-21 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
schemas: Add picture keys for screensaver (2.98 KB, patch)
2012-06-11 11:02 UTC, Bastien Nocera 		needs-work Details | Review
schemas: Add picture keys for screensaver (2.71 KB, patch)
2012-12-17 19:31 UTC, Giovanni Campagna 		committed Details | Review

Description Bastien Nocera 2012-06-11 11:02:12 UTC 
.
Comment 1 Bastien Nocera 2012-06-11 11:02:14 UTC 
Created attachment 216101 [details] [review]
schemas: Add picture keys for screensaver
Comment 2 Bastien Nocera 2012-06-11 11:05:15 UTC 
We could probably remove a bunch of the options, as this is a straight cut'n'paste of the background options.
Comment 3 Giovanni Campagna 2012-12-17 19:12:49 UTC 
Well, surely we can remove show-desktop-icons, but not anything else, as GnomeBG accesses all the other keys.

Anyway, this is blocking bug 688210.
Comment 4 Giovanni Campagna 2012-12-17 19:31:18 UTC 
Created attachment 231765 [details] [review]
schemas: Add picture keys for screensaver

Removed show-desktop-icons, which is not useful.
Comment 5 Bastien Nocera 2012-12-18 13:13:50 UTC 
Could we not have cleaned up the background options first?
Comment 6 Bastien Nocera 2013-01-23 09:50:18 UTC 
Review of attachment 231765 [details] [review]:

Can you please review the defaults with the designers? Looks fine to commit.
Hopefully we'll get to clean those up at some point.
Comment 7 Bastien Nocera 2013-02-21 11:20:26 UTC 
Attachment 231765 [details] pushed as de037d1 - schemas: Add picture keys for screensaver