After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677590 - messageTray: Don't show non urgent notifications while in fullscreen
messageTray: Don't show non urgent notifications while in fullscreen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 663147 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-06 22:30 UTC by drago01
Modified: 2012-10-31 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Don't show non urgent notifications while in fullscreen (3.37 KB, patch)
2012-06-06 22:30 UTC, drago01 		committed Details | Review
LayoutManager: Add primary-fullscreen-changed signal (1.95 KB, patch)
2012-06-06 22:31 UTC, drago01 		committed Details | Review

Description drago01 2012-06-06 22:30:54 UTC 
See patched and IRC discussion from #gnome-design:

---
<drago01>	I still do think that we should just not show (non critical) notifciations while in fullscreen (movie, presentation, game)
<jimmac>	sounds sane to me too
<mccann>	then you need to figure out what other ways you will do alerts
<mccann>	sound etc
<mccann>	just because I'm previewing a printout in fullscreen doesn't mean I don't want that
<drago01>	well we could queue them and show them once fullscreen is left
<drago01>	so once you are done with previewing
<drago01>	you get them
---
Comment 1 drago01 2012-06-06 22:30:56 UTC 
Created attachment 215793 [details] [review]
messageTray: Don't show non urgent notifications while in fullscreen

Don't show non urgent notifications when the primary monitor
is in fullscreen (user watching a movie, having a presentation,
playing a game ...).

Once the user leaves fullscreen show the messagetray so that the user don't
miss any notification (same as in "back from idle").
Comment 2 drago01 2012-06-06 22:31:25 UTC 
Created attachment 215794 [details] [review]
LayoutManager: Add primary-fullscreen-changed signal

Add a signal to the LayoutManager which gets emitted once the primary monitor
enters or leaves the fullscreen state.
Comment 3 drago01 2012-06-06 22:31:53 UTC 
Sorry for the wrong patch order, the first one goes first.
Comment 4 drago01 2012-06-06 22:32:07 UTC 
(In reply to comment #3)
> Sorry for the wrong patch order, the first one goes first.

Err .. the second one.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-06-07 18:32:56 UTC 
Review of attachment 215793 [details] [review]:

Sure.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-06-07 18:33:03 UTC 
Review of attachment 215794 [details] [review]:

Sure.
Comment 7 drago01 2012-06-07 18:35:14 UTC 
Attachment 215793 [details] pushed as f5933c8 - messageTray: Don't show non urgent notifications while in fullscreen
Attachment 215794 [details] pushed as 6700f86 - LayoutManager: Add primary-fullscreen-changed signal
Comment 8 Florian Müllner 2012-10-31 15:55:31 UTC 
*** Bug 663147 has been marked as a duplicate of this bug. ***