GNOME Bugzilla – Bug 677512
Port clock applet to 2012
Last modified: 2012-07-15 22:15:19 UTC
I had to do it because the broken dependency on libgweather is blocking 3.5.* from ever seeing light, and then I found it in a bad state of GConf, g_locale_from_utf8 back and forth, static buffers, manual signals instead of GBindings... This should bring an improvement.
Created attachment 215689 [details] [review] Clock Applet: port to modern GNOME technologies This is a big commit that updates the Clock Applet to use modern libraries. This includes using GSettings instead of GConf, using GDateTime instead of the equivalents from libc and using the new API in libgweather.
Created attachment 215933 [details] [review] Clock Applet: port to modern GNOME technologies This is a big commit that updates the Clock Applet to use modern libraries. This includes using GSettings instead of GConf, using GDateTime instead of the equivalents from libc and using the new API in libgweather. Tested now, seems to work.
Hrm, I guess you don't have a series of patch instead? It'd been much easier to review each changes separately.
No, it's one commit because it was just too messy to get individual changes in without breaking the build. Also, it is quite difficult to split for example the general GSettings port and the GSettings port for libgweather, or the general GSettings port or the GnomeWallClock rewrite (which in turn causes the other changes)
Comment on attachment 215933 [details] [review] Clock Applet: port to modern GNOME technologies I really won't be able to properly review that for now, so I guess it's simpler to just commit and have testers before 3.6.0.
It seems to work fine here, so I'm pushing it. Attachment 215933 [details] pushed as cd1a0db - Clock Applet: port to modern GNOME technologies
*** Bug 674714 has been marked as a duplicate of this bug. ***