GNOME Bugzilla – Bug 677502
fix compile warnings
Last modified: 2012-06-06 11:39:50 UTC
this patch set fixes differend kind of compiler warnings in gnome-sound-recorder code.
Created attachment 215668 [details] [review] grecord: Replace gtk_hbox_new with gtk_box_new Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Created attachment 215669 [details] [review] grecord: Replace gtk_vbox_new with gtk_box_new Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Created attachment 215670 [details] [review] grecord: Replace g_format_size_for_display with g_format_size Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Created attachment 215671 [details] [review] grecord: Replace %llu with G_GINT64_FORMAT Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Created attachment 215672 [details] [review] grecord: Replace gtk_hscale_new with gtk_scale_new Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Review of attachment 215668 [details] [review]: ::: grecord/src/gsr-window.c @@ +1098,3 @@ + hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0); + gtk_box_set_homogeneous (GTK_BOX (hbox), FALSE); the default value is already FALSE
Review of attachment 215669 [details] [review]: that patch is so similar to previous one that I would have merged them. ::: grecord/src/gsr-window.c @@ +1088,3 @@ + vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 18); + gtk_box_set_homogeneous (GTK_BOX (vbox), FALSE); the default value is FALSE.
Review of attachment 215670 [details] [review]: please bump configure.ac requirement when using newer function
Review of attachment 215671 [details] [review]: ack
Review of attachment 215672 [details] [review]: ::: grecord/src/gsr-window.c @@ +2344,3 @@ gtk_widget_show (content_vbox); + priv->scale = gtk_scale_new (GTK_ORIENTATION_HORIZONTAL, please bump configure.ac gtk version requirement before
Review of attachment 215668 [details] [review]: please bump configure.ac gtk version requirement
Created attachment 215707 [details] [review] grecord: Replace gtk_vbox_new with gtk_box_new v2: remove gtk_box_set_homogeneous (GTK_BOX (vbox), FALSE); Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Created attachment 215708 [details] [review] grecord: Replace gtk_hbox_new with gtk_box_new v2: remove gtk_box_set_homogeneous (GTK_BOX (hbox), FALSE); Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Created attachment 215709 [details] [review] gnome-media: update gtk version to 3.4.0 Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
The last patch should go before others.
Review of attachment 215709 [details] [review]: please merge this patch with the gtk_box_new() patches. thanks
Created attachment 215726 [details] [review] gnome-media: update gtk version to 3.4.0 and fix compile warnings: grecord: Replace gtk_hbox_new with gtk_box_new grecord: Replace gtk_vbox_new with gtk_box_new grecord: Replace g_format_size_for_display with g_format_size grecord: Replace gtk_hscale_new with gtk_scale_new Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
i merged all update related patches. IMHO, then it is better if git revert is needed.
Review of attachment 215726 [details] [review]: does this fix all gnome-media warnings or just grecord?
all gtk related. they all was only in grecord.
oops... one more found in gvc-sound-theme-chooser, it was hidden behind other warnings.
Created attachment 215728 [details] [review] gnome-media: update gtk version to 3.4.0 and fix compile warnings: grecord: Replace gtk_hbox_new with gtk_box_new grecord: Replace gtk_vbox_new with gtk_box_new grecord: Replace g_format_size_for_display with g_format_size grecord: Replace gtk_hscale_new with gtk_scale_new sound-theme: Replace gtk_hbox_new with gtk_box_new Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Review of attachment 215728 [details] [review]: ack
Attachment 215671 [details] pushed as 29add32 - grecord: Replace %llu with G_GINT64_FORMAT Attachment 215728 [details] pushed as 7bf2726 - gnome-media: update gtk version to 3.4.0