After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677463 - rtsp-client: GSocketAddress leak
rtsp-client: GSocketAddress leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-05 12:10 UTC by David Svensson Fors
Modified: 2012-06-06 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for fixing GSocketAddress leak in gst_rtsp_client_accept (716 bytes, patch)
2012-06-05 12:13 UTC, David Svensson Fors 		none Details | Review

Description David Svensson Fors 2012-06-05 12:10:01 UTC 
In gst_rtsp_client_accept, there is a GSocketAddress memory leak. The GSocketAddress returned by g_socket_get_remote_address is not unreffed. According to the documentation for g_socket_get_remote_address, it should be unreffed.

I have attached a patch for fixing this problem.
Comment 1 David Svensson Fors 2012-06-05 12:13:28 UTC 
Created attachment 215638 [details] [review]
Patch for fixing GSocketAddress leak in gst_rtsp_client_accept
Comment 2 Wim Taymans 2012-06-06 12:55:09 UTC 
commit 7b145aeeab24971a4e305b9f4fd26782f35365cd
Author: David Svensson Fors <davidsf at axis.com>
Date:   Wed Jun 6 14:49:02 2012 +0200

    client: fix GSocketAddress leak in gst_rtsp_client_accept
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=677463