After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677453 - Does not filter out file transfer notifications
Does not filter out file transfer notifications
Status: RESOLVED DUPLICATE of bug 676175
Product: gnome-shell
Classification: Core
Component: telepathy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-05 09:35 UTC by Guillaume Desmottes
Modified: 2012-06-06 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notificationDaemon: filter out Empathy file transfer notifications (1.22 KB, patch)
2012-06-05 09:36 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2012-06-05 09:35:13 UTC 
http://git.gnome.org/browse/gnome-shell/commit/?id=7458d3ef was meant to filter out file transfer notifications but it doesn't because of a stupid typo.
Comment 1 Guillaume Desmottes 2012-06-05 09:36:12 UTC 
Created attachment 215624 [details] [review]
notificationDaemon: filter out Empathy file transfer notifications

The Shell is handling incoming FT itself so they are not needed.
Comment 2 Florian Müllner 2012-06-05 13:28:38 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 676175 ***
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-05 13:29:10 UTC 
Review of attachment 215624 [details] [review]:

I thought we fixed this typo already. Go.
Comment 4 Florian Müllner 2012-06-05 14:07:38 UTC 
Yes we did, see bug 676175. I think this is for the 3.4 branch
Comment 5 Guillaume Desmottes 2012-06-06 08:11:42 UTC 
Indeed, it's for 3.4. Ok to cherry-pick the master patch to it?
Comment 6 Florian Müllner 2012-06-06 09:38:09 UTC 
Not sure how useful commits to the 3.4 branch are at this point, but sure, go ahead.