After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677284 - table-layout: Honor actors expand and alignment settings
table-layout: Honor actors expand and alignment settings
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-01 15:00 UTC by Bastian Winkler
Modified: 2012-06-04 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
table-layout: Honor actors expand and alignment settings (3.61 KB, patch)
2012-06-01 15:00 UTC, Bastian Winkler 		committed Details | Review

Description Bastian Winkler 2012-06-01 15:00:43 UTC 
Check if the actor has needs to expand and use Actor.allocate() instead
of Actor.allocate_align_fill in that case.
Comment 1 Bastian Winkler 2012-06-01 15:00:45 UTC 
Created attachment 215430 [details] [review]
table-layout: Honor actors expand and alignment settings
Comment 2 Emmanuele Bassi (:ebassi) 2012-06-04 11:44:28 UTC 
Review of attachment 215430 [details] [review]:

looks okay, apart from a couple of coding style issues.

::: clutter/clutter-table-layout.c
@@ +753,3 @@
       if (!col->expand)
+        col->expand = clutter_actor_needs_expand (child, orientation)
+          || meta->x_expand;

the || should go on the previous line, and the block should get curly braces around it.

@@ +803,2 @@
           if (!columns[i].expand)
+            columns[i].expand = clutter_actor_needs_expand (child, orientation)

same as above.

@@ +1026,3 @@
       if (!row->expand)
+        row->expand = clutter_actor_needs_expand (child, orientation) ||
+          meta->y_expand;

same as above

@@ +1078,3 @@
           if (!rows[i].expand)
+            rows[i].expand = clutter_actor_needs_expand (child, orientation) ||
+              meta->y_expand;

same as above
Comment 3 Bastian Winkler 2012-06-04 14:10:12 UTC 
Ok, I fixed the coding style issues

Attachment 215430 [details] pushed as a375848 - table-layout: Honor actors expand and alignment settings