After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677149 - network: make sure vlans are handled
network: make sure vlans are handled
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 677151
Blocks: 677147 677152
 
 
Reported: 2012-05-31 01:42 UTC by Matthias Clasen
Modified: 2012-10-31 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libnm-gtk: Always include interface name in bond/vlan names (3.76 KB, patch)
2012-10-18 11:58 UTC, Dan Winship 		committed Details | Review

Description Matthias Clasen 2012-05-31 01:42:48 UTC 
NetworkManager supports bridging nowadays; the network panel should show
something reasonable when it meets such a network configuration.

See http://fedoraproject.org/wiki/Features/NMEnterpriseNetworking

(Note: this bug is part of a series of bugs I'm filing for handling 'exotic'
network constellations)
Comment 1 Matthias Clasen 2012-06-19 23:36:18 UTC 
See bug 678210
Comment 2 Dan Winship 2012-08-27 15:08:29 UTC 
For ethernet VLANs (the common case), we could show these as just additional wired connections. Eg, following the suggestion in bug 677143, we'd have an entry for "Wired (eth0.1)" or "VLAN (eth0.1)", with the details page looking basically like the standard ethernet details page.

For other types, things get trickier, because the VLANs all have to share the same L2 configuration. Eg, VLANs on a Wi-Fi device would all be connected to the same SSID, so it wouldn't make sense to show the list of networks on each VLAN device's details page.

I'm still figuring out how to show this in nm-connection-editor.

Another possibility would be to show the VLANs as items on the parent device's details page rather than as separate devices. Eg, when I click "Wired", it would show the config for eth0, eth0.1, and eth0.2, rather than just eth0.
Comment 3 Dan Winship 2012-10-18 11:58:30 UTC 
The patch from bug 677151 makes these show up, with no VLAN-specific info. I'm attaching another patch, for libnm-gtk, which will make it always show the interface name as part of the device name. (ie, the list of devices will show "VLAN (eth0.1)" rather than just "VLAN", even if there's only one vlan device).
Comment 4 Dan Winship 2012-10-18 11:58:44 UTC 
Created attachment 226731 [details] [review]
libnm-gtk: Always include interface name in bond/vlan names

In the names returned by nma_utils_disambiguate_device_names(), always
include the interface name in bond and vlan names, since that's part
of the definition of the device for those types, not just an
implementation detail.
Comment 5 Matthias Clasen 2012-10-31 14:59:44 UTC 
could this get review ?
Comment 6 Dan Winship 2012-10-31 18:28:21 UTC 
(In reply to comment #5)
> could this get review ?

I had mostly attached it to make sure Bastien was OK with the UI change. Since he didn't object, I'll commit it.
Comment 7 Dan Winship 2012-10-31 18:29:02 UTC 
Attachment 226731 [details] pushed as 1c5975b - libnm-gtk: Always include interface name in bond/vlan names