GNOME Bugzilla – Bug 677145
network: make sure bridged devices are handled
Last modified: 2013-01-30 18:07:16 UTC
NetworkManager supports bridging nowadays; the network panel should show something reasonable when it meets such a network configuration. (Note: this bug is part of a series of bugs I'm filing for handling 'exotic' network constellations)
See http://fedoraproject.org/wiki/Features/NMEnterpriseNetworking
Created attachment 234728 [details] [review] network: add "virtual device" support, for bonds, bridges, and vlans Bond, bridge, and VLAN devices may not actually exist until their connections are brought up. So for those types, create device items (of type NetVirtualDevice or a subclass) as soon as we see the NMConnection, and then watch for the NMDevice being added later.
Created attachment 234729 [details] [review] network: add net_device_get_valid_connections() and use it everywhere In addition to simplifying a bunch of places that were calling nm_remote_settings_list_connections() + nm_device_filter_connections(), this also ensures we filter out slave connections everywhere (except when they are the active connection).
The first patch is also a fix to the existing bond and vlan support, which it turns out only worked right in certain circumstances. (In particular, it worked if your bond/vlan connection was autoconnect, but usually not if it wasn't.) This conflicts with bug 691721 of course, but hopefully we'll actually get an NM release out this time...
Review of attachment 234728 [details] [review]: Looks fine. ::: panels/network/net-virtual-device.c @@ +46,3 @@ +enum { + PROP_0, + extraneous line feeds here.
Review of attachment 234729 [details] [review]: ++ ::: panels/network/net-device-wifi.c @@ +1837,3 @@ } + + g_slist_free (connections); I'm guessing this should be a separate bug fix.