GNOME Bugzilla – Bug 677058
Refuse to add (legacy) status icons not part of the session mode
Last modified: 2012-05-29 20:07:06 UTC
Currently we add all legacy status icons that do not provide a shell implementation. As the session mode might deliberately not include certain icons, we don't want their fallback versions to show up either, so filter them out explicitly. (I'm aware that there's a workaround for the issue by including shell implementations for *all* icons, even those not in the order array, but that's completely unintuitive)
Created attachment 215215 [details] [review] panel: Refuse to add (legacy) status icons not part of the session mode If a session mode does not use certain status items, we don't want their fallback implementation to show up either, so filter them out.
Created attachment 215216 [details] [review] sessionMode: Add 'input-method' to status icons in user mode We now drop all status icons that are not explicitly enabled, which breaks the ibus icon. Add it to the list of allowed icons until we merge it with the keyboard one.
Review of attachment 215215 [details] [review]: ::: js/ui/panel.js @@ +1158,3 @@ + if (Main.sessionMode.statusArea.order.indexOf(role) == -1) { + // This icon is not used in the session mode, ignore it Comment isn't really needed.
Review of attachment 215216 [details] [review]: Sure.
Attachment 215215 [details] pushed as ebbd295 - panel: Refuse to add (legacy) status icons not part of the session mode Attachment 215216 [details] pushed as cb5ae92 - sessionMode: Add 'input-method' to status icons in user mode