After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677050 - Improve multi-selection
Improve multi-selection
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-05-29 17:06 UTC by drago01
Modified: 2012-08-30 02:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main-toolbar: add a set_labels_menu() method (4.19 KB, patch)
2012-08-29 21:04 UTC, Cosimo Cecchi
none Details | Review
main-view: add methods to select/unselect all (3.21 KB, patch)
2012-08-29 21:04 UTC, Cosimo Cecchi
none Details | Review
main-view: select range when Shift is being pressed (3.80 KB, patch)
2012-08-29 21:04 UTC, Cosimo Cecchi
none Details | Review
toolbar: add a Select All/Select None menu (4.99 KB, patch)
2012-08-29 21:05 UTC, Cosimo Cecchi
none Details | Review
screenshot (73.66 KB, image/png)
2012-08-29 21:11 UTC, Cosimo Cecchi
  Details

Description drago01 2012-05-29 17:06:37 UTC
The current interface is kind of awkward in case when the user wants to select a multiple items ... we should improve that.

See IRC discussion from #gnome-design:

-----
Mai 29 13:13:00 <drago01>	aday: question re selection widget (like the one we have in Documents) currently to select mutliple items you have to 1) switch to select mode 2) click on every single one you want to select
Mai 29 13:13:31 <drago01>	aday: can we add a way to select multiple ones by just dragging a rectangle (like in nautilus) maybe with a modifier key?
Mai 29 13:16:13 <drago01>	aday: or actually
Mai 29 13:16:18 <drago01>	aday: a "select all"
Mai 29 13:16:23 <drago01>	aday: would help my case
Mai 29 13:16:40 <drago01>	aday: (which is search for something and put them into a collection)
Mai 29 13:16:45 <aday>	rubber banding wouldn't work on touch
Mai 29 13:17:07 <aday>	multiple select is something that could be improved though, yea
Mai 29 13:17:43 <drago01>	yeah I know that it wouldn't work on touch
Mai 29 13:17:55 <drago01>	not sure how to make multi select easier on touch though
Mai 29 13:18:02 <jimmac>	i think cases like improting from devices really ask for a select all
Mai 29 13:18:02 <drago01>	a select all button would help
Mai 29 13:18:46 <drago01>	I mean why would we have the user select 50 documents by hand when the app could just do that for him
Mai 29 13:18:53 *	mclasen wants rubberbanding too
Mai 29 13:19:35 <mclasen>	I'll use a mouse when rubberbanding - the current interface feels a bit awkward when used with a  mouse
Mai 29 13:20:04 <aday>	i'd agree with that
Mai 29 13:20:10 <drago01>	yeah
Mai 29 13:20:24 <aday>	maybe not awkward, but perhaps slower than we're used to
Mai 29 13:20:48 *	andre_ hat die Verbindung getrennt (andre_)
Mai 29 13:21:18 *	darkmatter (~darkmatte@142-165-56-143.yktn.hsdb.sasknet.sk.ca) hat #gnome-design betreten
Mai 29 13:21:27 <aday>	perhaps we could add shift + ctrl modifiers
Mai 29 13:21:48 <drago01>	well when using a mouse rubberbanding is kind of "expected to work"  having it not work is what makes for the akward feeling
Mai 29 13:22:15 *	mikehill (~Android@out-on-188.wireless.telus.com) hat #gnome-design betreten
Mai 29 13:22:20 <aday>	i never use it tbh
Mai 29 13:22:33 *	darkmatter hat die Verbindung getrennt (Слава!)
Mai 29 13:22:36 <aday>	it's too fiddly
Mai 29 13:23:59 *	elleuca hat die Verbindung getrennt (Ex-Chat)
Mai 29 13:24:36 <drago01>	anyway we should fix that for 3.6 (as we are having more and more apps with the new selection pattern) by fix I mean having a select all (to make multi select easier on touch) and probably add rubberbanding for mouse interaction
-----------
Comment 1 Allan Day 2012-07-06 13:35:59 UTC
One obvious thing we could do here is add for support for using a Shift modifier to select runs of items. There might be other things we can do; I'd need to discuss it with Jon and Jimmac though.
Comment 2 Cosimo Cecchi 2012-08-29 21:04:06 UTC
Created attachment 222849 [details] [review]
main-toolbar: add a set_labels_menu() method

This method adds a menu to the labels section in the center of the
toolbar. It can be disabled by setting the model back to NULL.
Comment 3 Cosimo Cecchi 2012-08-29 21:04:33 UTC
Created attachment 222850 [details] [review]
main-view: add methods to select/unselect all
Comment 4 Cosimo Cecchi 2012-08-29 21:04:58 UTC
Created attachment 222851 [details] [review]
main-view: select range when Shift is being pressed
Comment 5 Cosimo Cecchi 2012-08-29 21:05:32 UTC
Created attachment 222852 [details] [review]
toolbar: add a Select All/Select None menu

As seen in recent mockups. This commit implements that menu using the
new method of GdMainToolbar.
Comment 6 Cosimo Cecchi 2012-08-29 21:11:32 UTC
Created attachment 222865 [details]
screenshot

Screenshot of the selection toolbar menu.
Comment 7 Cosimo Cecchi 2012-08-30 02:07:53 UTC
Pushed to master after r-t approval.