After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677001 - extensionUtils: Support subdirectories in getCurrentExtension
extensionUtils: Support subdirectories in getCurrentExtension
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-28 23:41 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-05-29 18:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extensionUtils: Support subdirectories in getCurrentExtension (1.56 KB, patch)
2012-05-28 23:41 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-05-28 23:41:12 UTC 
A recently submitted gnome-shell extension made a hack to get around this.
Let's give them what they wanted for the next edition of the Shell.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-05-28 23:41:14 UTC 
Created attachment 215158 [details] [review]
extensionUtils: Support subdirectories in getCurrentExtension

Some extensions may have complex layouts with multiple subdirectories.
Currently, getCurrentExtension doesn't support this, as it uses a regex
and assume's that the last path's component's parent is all that's needed.
Fix this.
Comment 2 Giovanni Campagna 2012-05-29 18:27:29 UTC 
Review of attachment 215158 [details] [review]:

Looks good
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-05-29 18:36:43 UTC 
Attachment 215158 [details] pushed as 65d23fb - extensionUtils: Support subdirectories in getCurrentExtension