After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676904 - ephy-web-view: remove unused EphyWebViewChrome elements
ephy-web-view: remove unused EphyWebViewChrome elements
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-26 22:35 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-06-14 23:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-web-view: remove unused EphyWebViewChrome elements (2.40 KB, patch)
2012-05-26 22:35 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:35:45 UTC
Could not find uses for this now that all this chrome does not exist.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:35:46 UTC
Created attachment 215075 [details] [review]
ephy-web-view: remove unused EphyWebViewChrome elements
Comment 2 Xan Lopez 2012-06-13 17:13:03 UTC
Review of attachment 215075 [details] [review]:

OK with a small nitpick.

::: src/ephy-shell.c
@@ +517,1 @@
   /* what's a popup ? ATM, any window opened with menubar toggled on

Update the comment while you are it.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-06-14 23:24:11 UTC
Updated the comment!

Attachment 215075 [details] pushed as bab0d69 - ephy-web-view: remove unused EphyWebViewChrome elements