After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676782 - Add a grayscale effect
Add a grayscale effect
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 676783
Blocks: 676817
 
 
Reported: 2012-05-24 22:39 UTC by Matthias Clasen
Modified: 2012-07-06 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a grayscale effect (18.47 KB, patch)
2012-05-24 22:39 UTC, Matthias Clasen 		none Details | Review
Add a grayscale effect (5.50 KB, patch)
2012-07-05 18:19 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Matthias Clasen 2012-05-24 22:39:52 UTC 
This commit adds a grayscale effect to the magnifier, similar to
the lightness, brightness and contrast effects that are already there.

The effect is configured with the
org.gnome.desktop.a11y.magnifier.color-saturation setting, which
can take values from 0.0 (grayscale) to 1.0 (full color).
Comment 1 Matthias Clasen 2012-05-24 22:39:54 UTC 
Created attachment 214907 [details] [review]
Add a grayscale effect
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-05-24 22:48:21 UTC 
ClutterDesaturateEffect?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-05-24 22:49:21 UTC 
(It even uses the same NTSC color primaries!)
Comment 4 Matthias Clasen 2012-05-25 00:49:27 UTC 
Didn't know that existed...
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-05-25 07:10:26 UTC 
Do you want to take another shot at the patch with ClutterDesaturateEffect, or should I whip up a quick one?
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-05-25 07:11:00 UTC 
Also, ClutterDesaturateEffect doesn't seem to use the CoglSnippet system. Maybe we can port some of your changes back into Clutter.
Comment 7 Matthias Clasen 2012-05-25 13:04:57 UTC 
Oh, I was just doing this while filling an hour of waiting for something else - feel free to clean it up. I'm not going to spend more time on it in the near term.

I do think having grayscale rendering would be a useful addition to our a11y support.
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-07-05 18:19:01 UTC 
Created attachment 218115 [details] [review]
Add a grayscale effect

This commit adds a grayscale effect to the magnifier, similar to
the lightness, brightness and contrast effects that are already there.

The effect is configured with the
org.gnome.desktop.a11y.magnifier.color-saturation setting, which
can take values from 0.0 (grayscale) to 1.0 (full color).

Based on a patch by Matthias Clasen <mclasen@redhat.com>
Comment 9 Matthias Clasen 2012-07-05 20:02:03 UTC 
Looks good to me, fwiw
Comment 10 drago01 2012-07-06 19:14:27 UTC 
Review of attachment 218115 [details] [review]:

Looks good.
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-07-06 19:18:19 UTC 
Attachment 218115 [details] pushed as 8754b27 - Add a grayscale effect