Created attachment 214876 [details] [review]
lib: Add libmusicbrainz5 support

Untested.

I think we should just drop libmusicbrainz4 support, not much point in keeping it around imo.

Review of attachment 214876 [details] [review]:

Isn't libmusicbrainz5 just v4 with a bumped soname?  Just checking for libmusicbrainz4 or libmusicbrainz5 at configure time should do the job.

Bumped soname + s/mb4_/mb5_ everywhere + a few deprecated functions dropped. things would be too easy otherwise ;)

Review of attachment 214876 [details] [review]:

Ha, typical.

Yes, let's just drop mb4 support.

Created attachment 215411 [details] [review]
drop musicbrainz 3 + 4, use 5

Do you want to drop mb3 support as well?  I hacked this up this morning. Testing limited to compiling, running sound-juicer and observing correct metadata for a single-disc release, using ldd to confirm it was linking to the right lib.

Sadly the only multi-disc release I have here does not read properly (suspect Sony DRM) so I haven't been able to test that (which was the driver for me to look at this)

Yeah, let's drop mb3 as well, it's no longer working anyway. However, I'd prefer to merge the musicbrainz bits from bug #661646 before committing this patch as I'm worried the 2 will badly commit, and the mb5 patch is mostly some sed work(?)

I've just re-tried my patch here and it isn't presenting the metadata for any multi-disc albums for me, sadly. More work needed.

I think I have a working one now; just doing a rip and listen test and some cleanup.

Created attachment 216349 [details] [review]
Update sound-juicer to use version 5 of musicbrainz.

Tested with two multi-disc releases and it worked fine for both.

I've pushed this, since I've pushed the changes from bug #661646
first, I had to fix a few conflicts and I edited the commit log to make
it more accurate