After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676726 - Fix compilation on android NDK
Fix compilation on android NDK
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-24 09:56 UTC by Lionel Landwerlin
Modified: 2012-08-20 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch v1 (609 bytes, patch)
2012-07-21 14:12 UTC, Lionel Landwerlin
none Details | Review
patch v2 (1.91 KB, patch)
2012-08-02 14:55 UTC, Lionel Landwerlin
accepted-commit_now Details | Review

Description Lionel Landwerlin 2012-05-24 09:56:58 UTC
Gio sniffing won't work on android.
Comment 1 Lionel Landwerlin 2012-07-21 14:12:00 UTC
Created attachment 219383 [details] [review]
patch v1

Sorry I just realized I didn't attached the patch...
Comment 2 Matthias Clasen 2012-07-22 19:35:44 UTC
Why won't it ?
Comment 3 Lionel Landwerlin 2012-07-23 09:21:29 UTC
Because we're cross compiling for ARM and we can't execute the compiled program in configure.
Comment 4 Matthias Clasen 2012-07-23 14:47:27 UTC
Hmm, so you want to disable the sniffing test when cross-compiling. But do you also want gdk-pixbuf to not use gio for sniffin at runtime ? I think our configury is currently not set up to say 'you can't test gio sniffing at configure time, but use it at runtime anyway'.
Comment 5 Thomas Wood 2012-08-02 10:10:42 UTC
The sniffing feature requires shared-mime-info to be installed on the file system, which is not usually possible on Android.

However, the test cannot be run when cross compiling anyway, so gdk-pixbuf should probably have a sensible default value for the result of this check when it is being cross compiled.
Comment 6 Ross Burton 2012-08-02 10:14:20 UTC
A default value when cross-compiling is hard to say -- you'll want "no" but in oe-core we'll probably want "yes".

If the test is written correctly then the cross-compilation environment can set the result beforehand using the site variables, and it will clearly fail when cross-compiling without a value.

(pretty sure glib does this for stuff like structure alignment tests)
Comment 7 Lionel Landwerlin 2012-08-02 14:55:38 UTC
Created attachment 220156 [details] [review]
patch v2

Following Thomas & Ross comments, it is now obvious to me that this is a cross compilation problem. We can't detect gio-sniff support when cross compiling, therefore the only way to fix this is to add an option to allow force gio-sniff enabled/disabled at configure time.
Comment 8 Ross Burton 2012-08-02 14:59:30 UTC
Looks great to me.
Comment 9 Matthias Clasen 2012-08-20 11:00:18 UTC
Review of attachment 220156 [details] [review]:

Looks fine to me
Comment 10 Lionel Landwerlin 2012-08-20 13:46:54 UTC
Pushed to master.