After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676602 - Port to GMenu
Port to GMenu
Status: RESOLVED FIXED
Product: hitori
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: hitori-maint
hitori-maint
Depends on: 676601
Blocks: 674957
 
 
Reported: 2012-05-22 22:41 UTC by Philip Withnall
Modified: 2012-09-29 01:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Philip Withnall 2012-05-22 22:41:19 UTC
Once Hitori has been ported to GtkApplication (bug #676601) at least some of its Game menu can be ported to GMenu.

https://live.gnome.org/GnomeGoals/PortToGMenu
Comment 1 Philip Withnall 2012-09-29 01:42:53 UTC
commit 941ab835037bbaf685131868a022b54387645273
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Sep 29 02:39:46 2012 +0100

    Bug 676602 — Port to GMenu
    
    Split the menu up into an application and a window menu, and port them both
    to GMenu/GAction.
    
    The new menu layout is:
     • Application:
      - New Game
      - About Hitori
      - Help
      - Quit
     • Window:
      - Board Size (with submenu)
      - Hint
      - Undo
      - Redo
    
    This was chosen because the actions in the window menu all perform some
    operation specifically on the contents of the main window. It’s arguable
    that ‘New Game’ should also be there, but that could be considered to open
    a new main window, sort of, so it’s in the application menu.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=676602

 data/hitori.ui  | 258 +++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------
 src/interface.c | 192 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
 src/main.c      |  16 ++++-----
 src/main.h      |   6 ++--
 4 files changed, 221 insertions(+), 251 deletions(-)
Comment 2 Philip Withnall 2012-09-29 01:48:14 UTC
Make that commit e40104c541facd63a5cb21c1e4572ad0ef1aa209 instead.