GNOME Bugzilla – Bug 676569
Use GTK_STYLE_CLASS_OSD
Last modified: 2012-05-31 20:25:59 UTC
From empathy-call-window.c: /* FIXME: we should use a stock "OSD" style class for the toolbar, * once it's available in GTK+/Adwaita. */
Created attachment 214663 [details] [review] call-window: use GTK_STYLE_CLASS_OSD
Created attachment 214664 [details] screenshot Here is how it looks like with this patch. The toolbar looks pretty big to me, is that normal? We shouldn't forget to bump the Gtk+ dep to 3.5.1 before merging this.
Created attachment 214967 [details] [review] call-window: use GTK_STYLE_CLASS_OSD for the floating toolbar
Created attachment 214968 [details] [review] call-window: use a linked style for the OSD toolbar buttons Pack the camera/volume/mic buttons in a GtkBox, so they get linked together by the theme. Also, use symbolic icons for the buttons in the toolbar, in GNOME 3 style.
Hey Guillaume, I spent some time yesterday on improving the style for OSD toolbars in Adwaita - the first patch here is analogous to your initial patch - the second one reworks how buttons are packed into the toolbar container, to get a linked effect from the theme automatically, and turns the icons into symbolic You need gnome-themes-standard master to get the intended style if you want to test them.
Thanks a lot for your work on this Cosimo. The toolbar still seems pretty massive to me. Can't we reduce its height a bit?
(In reply to comment #6) > Thanks a lot for your work on this Cosimo. > > The toolbar still seems pretty massive to me. Can't we reduce its height a bit? Yeah, the theme was still adding too much vertical padding to the buttons. I now fixed this in git master of gnome-themes-standard to match the mockups here [1]. [1] https://github.com/gnome-design-team/gnome-mockups/raw/master/theming/widgets/widget-factory.png
Looks good, please merge to master. Btw, the toolbar doesn't seem to have the rounded corner as in the mockup here.
Attachment 214967 [details] pushed as a018456 - call-window: use GTK_STYLE_CLASS_OSD for the floating toolbar Attachment 214968 [details] pushed as a402dd4 - call-window: use a linked style for the OSD toolbar buttons Thanks, pushed to master. I will investigate the missing rounded corners, it seems to be a more general problem.