After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676427 - use mingw C99 compatible functions {v}snprintf instead those from MSVC runtime
use mingw C99 compatible functions {v}snprintf instead those from MSVC runtime
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Windows
: Normal enhancement
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-20 15:13 UTC by Roumen Petrov
Modified: 2012-05-21 02:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove use of _{v}snprintf for mingw* build (3.91 KB, patch)
2012-05-20 15:13 UTC, Roumen Petrov
none Details | Review

Description Roumen Petrov 2012-05-20 15:13:34 UTC
Created attachment 214496 [details] [review]
remove use of _{v}snprintf for mingw* build

Since version 3.15 mingw runtime (released in 2008) offer C99 compatible functions {v}snprintf - see release note http://sourceforge.net/project/shownotes.php?release_id=24832 .

The proposed patch remove redefinition of {v}snprintf to _{v}snprintf for mingw* builds.

Result is not visible in libxml regression tests but in libxslt . As example if environment variable PRINTF_EXPONENT_DIGITS is set to 2 libxslt tests pass - you could check quickly in tests/exslt/math.
Comment 1 Daniel Veillard 2012-05-21 02:28:07 UTC
Okay, looks fine, I commented upstream,

applied and pushed:

  http://git.gnome.org/browse/libxml2/commit/?id=978ff224b2284f50bfb59c70b92a4b77bd4a7388

  thanks !

Daniel