After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676108 - build: OpenBSD needs _XOPEN_SOURCE_EXTENDED for strptime(3)
build: OpenBSD needs _XOPEN_SOURCE_EXTENDED for strptime(3)
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.4.x (obsolete)
Other OpenBSD
: Normal major
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-05-15 15:47 UTC by Antoine Jacoutot
Modified: 2012-05-21 00:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add a defined for _XOPEN_SOURCE_EXTENDED (850 bytes, patch)
2012-05-15 15:47 UTC, Antoine Jacoutot 		committed Details | Review

Description Antoine Jacoutot 2012-05-15 15:47:58 UTC 
Created attachment 214126 [details] [review]
add a defined for _XOPEN_SOURCE_EXTENDED

Hi.

strptime(3) was introduced in XPG4.
On OpenBSD, just defining _XOPEN_SOURCE gets you the older XPG3 wich doesn't include strptime(3).
To get XPG4, you'll have to add #define _XOPEN_VERSION 4, but doing that may cause some issues.  So it is probably better to just ask for XPG4v2 by adding #define _XOPEN_SOURCE_EXTENDED 1.

Thoughts?
Comment 1 Matthew Barnes 2012-05-21 00:33:43 UTC 
Looks fine to me, thanks for the patch.

Didn't test build it myself on OpenBSD but I'll take your word for it.

Committed for Evolution 3.5.2 and 3.4.3:

http://git.gnome.org/browse/evolution-data-server/commit/?id=2236bc3631b8f8c4995dabf65d27cdc39c7493f9

http://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-3-4&id=6fe2278f6dc8105ff128166ef232498ad8ab5f8d