GNOME Bugzilla – Bug 676084
split language-support-cpp-java plugin in an indentation part and a new language-support-cpp-java part
Last modified: 2012-07-26 14:44:55 UTC
Created attachment 214073 [details] [review] split old language-support-cpp-java plugin in indentation-c-style and new language-support-cpp-java I'd split the old language-support-cpp-java plugin in an indentation part and a new language-support-cpp-java part.
Review of attachment 214073 [details] [review]: Thanks, looks good overall, please have a look at the detailed comments below. ::: plugins/indentation-c-style/anjuta-indentation-c-style.plugin.in @@ +4,3 @@ +_Name=C style indentation Plugin +_Description=auto-indentation for c style code +Interfaces=IAnjutaLanguageSupport,IAnjutaIndenter Not sure if you need IAnjutaLanguageSupport here. ::: plugins/indentation-c-style/utils.c @@ +19,3 @@ +*/ + +#include <libanjuta/interfaces/ianjuta-editor-cell.h> utils.c and utils.h should probably just be integrated into libanjuta/anjuta-utils.c/h so you can use them from both, c and python plugin. ::: plugins/language-support-js/lex.yy.c @@ +2857,3 @@ static int yy_get_next_buffer (void) { + register char *dest = YY_CURRENT_BUFFER_LVALUE->yy_ch_buf; were the changes to this file intentional?
*** Bug 676305 has been marked as a duplicate of this bug. ***
Created attachment 214311 [details] [review] split language-support-cpp-java and language-support-python plugin in an indentation part and a new language-support part I made one patch for both plugins, language-support-cpp-java and language-support-python. > Not sure if you need IAnjutaLanguageSupport here. * If I remove IAnjutaLanguageSupport, the indentation doesn't work. > utils.c and utils.h should probably just be integrated into libanjuta/anjuta-utils.c/h so you can use them from both, c and python plugin. * The plugins use libanjuta/anjuta-utils.c/h now. > were the changes to this file intentional? * Yes, but this is only cosmetic. So in the new patch this file is untouched.
Fantastic work - thanks! There is a small problem though when the preferences are openen while a python file open I get the following: GLib-GIO-ERROR **: Settings schema 'org.gnome.anjuta.plugins.python' does not contain a key named 'indent-automatic' Can you please check that? I pushed the other changes so you can create a subsequent patch.
Created attachment 214821 [details] [review] fix preferences string in indentation-c-style and indentation-python-style This shouldn't happen. I tried to reproduce the error, but I didn't get it displayed. language-support-python plugin never uses the key "indent-automatic" and indentation-python-style uses the settings schema "org.gnome.anjuta.plugins.indent-python". Are you sure that you build the plugins in a clean environment without old temporary files? I recognize that you forgot to rename two strings. (see attached patch)
Created attachment 217017 [details] [review] Some trivial fixes in indentation plugins and cpp-java plugin Additionally to the old patch I removed IAnjutaIndenter in the python and the cpp-java plugin and vala support in thecpp-java plugin.
Created attachment 217111 [details] [review] fix ui file of cpp-java plugin I found three lines in the code, which I forgot to delete.
Review of attachment 217017 [details] [review]: Thanks!
Review of attachment 217111 [details] [review]: Hmm, the patch doesn't apply and seems to work without problems here.
(In reply to comment #9) > Review of attachment 217111 [details] [review]: > > Hmm, the patch doesn't apply and seems to work without problems here. Ohh, I forgot that this patch fixes a problem which affects only my work branch. So forget this patch. :-)
This is all in master.