After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675785 - highlighting current line does not work
highlighting current line does not work
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
: 686116 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-05-09 23:52 UTC by hpvpp@optusnet.com.au
Modified: 2013-01-26 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description hpvpp@optusnet.com.au 2012-05-09 23:52:00 UTC
The preference allows for the current line to be highlighted.  It used to work under Ubuntu 11.xx, it does not work under Ubuntu 12.04.
Comment 1 André Klapper 2012-05-10 15:58:40 UTC
Please provide exact steps to reproduce this (e.g. where to find this and what to do).
Comment 2 hpvpp@optusnet.com.au 2012-05-10 22:48:03 UTC
I have ticked "highlight current line" in the preferences and so when I start gedit (by clicking on a file or typing "gedit <filename>" in a terminal) I expect the current line (wherever that might be) to be highlighted.  It isn't.
Comment 3 jessevdk@gmail.com 2012-05-11 08:14:06 UTC
I can confirm that this occurs with the Ubuntu Ambiance theme, for either the classic or tango gsv styles. The problem is that those styles do not set an explicit current-line color, nor do they set an explicit foreground/background color. In the Adwaita theme this leads to having no 'apparent' current line highlighting since the background color and the base color are the same in Adwaita.

For a quick fix, just change gsv style if you want. The proper fix I guess would not to rely on any theming from the desktop theme for the classic and tango styles.
Comment 4 Ignacio Casal Quinteiro (nacho) 2012-05-11 08:15:48 UTC
dunno, the proper fix would be to fix the themes. See that the point of this themes is to be as close to the desktop theme as possible
Comment 5 Paolo Borelli 2012-09-17 19:56:36 UTC
This is a bug in ubuntu themes
Comment 6 Sébastien Wilmet 2012-12-20 20:30:05 UTC
I reopen this bug because it has reappeared in GNOME 3.6 and above.

To summarize:
- with GTK+ 3.4 and Adwaita: no problem.
- with GTK+ 3.4 without Adwaita (vanilla/ugly theme): the bug occurs.
- with GTK+ 3.6 or above, with or without Adwaita: the bug occurs.

Where should the bug be fixed? In the GtkSourceView style schemes (tango and classic), gnome-themes-standard, or directly in GTK+ (for fixing the vanilla/ugly theme) ?
Comment 7 Ignacio Casal Quinteiro (nacho) 2013-01-24 13:20:21 UTC
I guess that we should just fix it at gtksourceview level. pbor thoughts?
Comment 8 Ignacio Casal Quinteiro (nacho) 2013-01-25 13:45:52 UTC
*** Bug 686116 has been marked as a duplicate of this bug. ***
Comment 9 Ignacio Casal Quinteiro (nacho) 2013-01-26 13:42:12 UTC
I fixed this and made a new stable release. I am already updating the package for fedora 18. The ones with ubuntu or other distros will have to wait for it.