After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675762 - x264enc: Deadlock on property changes
x264enc: Deadlock on property changes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.x
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-09 16:04 UTC by Nicolas Dufresne (ndufresne)
Modified: 2012-05-10 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x264enc: Don't set latency while holding object lock (3.84 KB, patch)
2012-05-09 16:07 UTC, Nicolas Dufresne (ndufresne) 		none Details | Review
x264enc: Don't set latency while holding object lock (3.79 KB, patch)
2012-05-09 16:10 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2012-05-09 16:04:30 UTC 
This was initially fixed using the stream lock (commit 30a0b50e9ca0d625e61f994d4f8acd022dcddf38) instead of the object lock, but this is conceptually wrong and may cause deadlock if properties are changed in paused state.
Comment 1 Nicolas Dufresne (ndufresne) 2012-05-09 16:07:39 UTC 
Created attachment 213749 [details] [review]
x264enc: Don't set latency while holding object lock

This reverts commit 30a0b50e9ca0d625e61f994d4f8acd022dcddf38.

https://bugzilla.gnome.org/show_bug.cgi?id=675761
Comment 2 Nicolas Dufresne (ndufresne) 2012-05-09 16:10:32 UTC 
Created attachment 213750 [details] [review]
x264enc: Don't set latency while holding object lock

This reverts commit 30a0b50e9ca0d625e61f994d4f8acd022dcddf38.
Comment 3 Nicolas Dufresne (ndufresne) 2012-05-09 18:20:54 UTC 
Can also be seen at:
http://cgit.collabora.com/git/user/nicolas/gst-plugins-ugly2.git/log/?h=675762-deadlock-setting-latency
Comment 4 Sebastian Dröge (slomo) 2012-05-10 14:00:05 UTC 
commit 6814275662e3874ed63dc170335839d8cccf5f6e
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Mon May 7 11:52:40 2012 -0400

    x264enc: Don't set latency while holding object lock
    
    This reverts commit 30a0b50e9ca0d625e61f994d4f8acd022dcddf38.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=675762