After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675600 - dshowvideosink: Add missing cast to LPCSTR
dshowvideosink: Add missing cast to LPCSTR
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-07 10:53 UTC by Andoni Morales
Modified: 2012-05-07 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add missing casts to LPCSTR (2.99 KB, patch)
2012-05-07 11:07 UTC, Andoni Morales
committed Details | Review

Description Andoni Morales 2012-05-07 10:53:16 UTC
A cast to LPCSTR is missing in some places
Comment 1 Andoni Morales 2012-05-07 11:07:54 UTC
Created attachment 213576 [details] [review]
Add missing casts to LPCSTR
Comment 2 Sebastian Dröge (slomo) 2012-05-07 11:09:40 UTC
commit d3cc27f4fc57b2c12bf65abaf14408f3adf9b266
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Wed May 2 08:03:46 2012 -0700

    dshowvideosink: add missing casts to LPCSTR
Comment 3 Raimo Järvi 2012-05-07 16:14:24 UTC
If you really want to hard code it to using ANSI strings, shouldn't you use GetPropA etc. that take LPCSTR parameters?