After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675598 - gstcompat.h: should be hidden by DISABLE_DEPRECATED
gstcompat.h: should be hidden by DISABLE_DEPRECATED
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-07 10:23 UTC by Javier Jardón (IRC: jjardon)
Modified: 2018-01-28 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove no-op code (951 bytes, patch)
2012-05-07 10:24 UTC, Javier Jardón (IRC: jjardon) 		rejected Details | Review

Description Javier Jardón (IRC: jjardon) 2012-05-07 10:23:47 UTC 
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2012-05-07 10:24:41 UTC 
Created attachment 213570 [details] [review]
Remove no-op code
Comment 2 Tim-Philipp Müller 2012-05-07 15:25:51 UTC 
Yeah, I noticed that too, but I don't think it's quite right.

The entire header should really be inside ifndef _DISABLE_DEPRECATED, but more work all over the place needs to be done before that doesn't cause breakage in other modules.
Comment 3 Tim-Philipp Müller 2012-05-07 15:26:12 UTC 
Comment on attachment 213570 [details] [review]
Remove no-op code

Rejecting for now, in the hope that we'll manage to fix it properly :)
Comment 4 Olivier Crête 2012-09-26 16:35:13 UTC 
If we want to block gstcompat.h, it probably makes sense to make gst_pad_set_caps() to gstutils.h, as it's seriously convenient.
Comment 5 Tim-Philipp Müller 2012-09-26 16:43:50 UTC 
Maybe it should be _send_caps() then to make it more obvious that an event is being sent?
Comment 6 Tim-Philipp Müller 2018-01-28 21:30:44 UTC 
I don't think anything needs to be done here let's close it :)