GNOME Bugzilla – Bug 675527
Bug in searchDisplay.js in line 138, for IconGrid never show more than 1 row
Last modified: 2012-07-13 03:42:35 UTC
(while writing extensions ..) if you create a new IconGrid with let grid = new IconGrid.IconGrid({ rowLimit: MAX_ROWS, columnLimit: MAX_RESULTS, xAlign: St.Align.START }); the IconGrid is properly created, but when populated with results, never more than one row is shown. This is due line 138 in searchDisplay.js where the max row property is hard coded, changing "MAX_SEARCH_RESULTS_ROWS" to "this._grid._rowLimit" fixes the problem.
Question: Could I fix it my self, and create a pull request, or do i need to be an approved bugfixer , or does this bug need to be confirmed by s.o. else first ?
(In reply to comment #1) > Question: Could I fix it my self, and create a pull request That would be great - rather than a pull request, you should create a patch with git-format-patch and attach it here though.
Created attachment 213663 [details] [review] proposed patch
Review of attachment 213663 [details] [review]: _rowLimit is private, so no. You should modify iconGrid.js to make it public as well.
Created attachment 213700 [details] [review] 2nd proposal patch huh, didn't know js supports the concept of private & public ;) but now read about it, and adjusted the patch.
(In reply to comment #5) > huh, didn't know js supports the concept of private & public It doesn't. It's just a convention we have.
Review of attachment 213700 [details] [review]: Sure.
Actually I've been wondering if this is actually a bug, e.g. should the number of rows be a per-provider property (like with this patch), or should rows-per-provider be a property of the search display (like it is now, to give equal space to each provider)?
(In reply to comment #8) > Actually I've been wondering if this is actually a bug, e.g. should the number > of rows be a per-provider property (like with this patch), or should > rows-per-provider be a property of the search display (like it is now, to give > equal space to each provider)? I think if we have a property, we should use it, not just drop it on the ground half the time. Christian, do you need somebody to push the patch for you?
> Christian, do you need somebody to push the patch for you? Yes, that'd be nice!
I pushed this a while ago.