After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675300 - "Password" string appears untranslated
"Password" string appears untranslated
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-02 14:30 UTC by Piotr Drąg
Modified: 2012-06-29 21:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PolkitAgent: Look for the right password prompt (1.10 KB, patch)
2012-06-27 23:23 UTC, Matthias Clasen
accepted-commit_now Details | Review
PolkitAgent: Look for the right password prompt (1.10 KB, patch)
2012-06-29 21:54 UTC, Matthias Clasen
committed Details | Review

Description Piotr Drąg 2012-05-02 14:30:50 UTC
When polkit authentication dialog is shown, the string "Password" often appears untranslated. It's fine in network connection dialogs, but it's in English on e.g. disk mounting dialog. It's not dependent of a locale, see:

http://people.freedesktop.org/~david/udisks2-translations-pt_BR.png
Comment 1 Matthias Clasen 2012-05-07 12:19:19 UTC
A few things to notice here:

- the polkit dialog looks for "Password:" and translates, the network dialog looks for "Password: ". That should probably be made consistent

- the prompt in the polkit dialog probably comes straight out of some pam module, and a quick search in pam finds "Password: " there.
Comment 2 Matthias Clasen 2012-06-27 23:23:10 UTC
Created attachment 217470 [details] [review]
PolkitAgent: Look for the right password prompt

Pam seems to give us different strings, sometimes 'Password:',
sometimes 'Password: '. Look for both of these when replacing
them with a translated prompt.
Comment 3 drago01 2012-06-28 22:27:33 UTC
Review of attachment 217470 [details] [review]:

Looks good.
Comment 4 Matthias Clasen 2012-06-29 21:54:30 UTC
The following fix has been pushed:
46cf9fa PolkitAgent: Look for the right password prompt
Comment 5 Matthias Clasen 2012-06-29 21:54:33 UTC
Created attachment 217662 [details] [review]
PolkitAgent: Look for the right password prompt

Pam seems to give us different strings, sometimes 'Password:',
sometimes 'Password: '. Look for both of these when replacing
them with a translated prompt.