After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675155 - Shouldn't warning when failing to parse bday field
Shouldn't warning when failing to parse bday field
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
: 663177 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-04-30 13:08 UTC by Guillaume Desmottes
Modified: 2012-04-30 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Raise a debug message rather than a warning when failing to parse bday field (1.01 KB, patch)
2012-04-30 13:09 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-04-30 13:08:26 UTC
I got a lot of those:

(gnome-contacts:1585): telepathy-WARNING **: tpf-persona.vala:878: Failed to parse new birthday string '24 avril 1988'


Strictly speaking, Folks is right assuming the bday field is in ISO 8601 as that's how it's defined in the vCard spec but in pratice loads of clients are doing it wrong and allow user to enter whatever shit they want.

I propose to decrease this warning to a debug as there is not much we can do about it.
Comment 1 Guillaume Desmottes 2012-04-30 13:09:59 UTC
Created attachment 213102 [details] [review]
Raise a debug message rather than a warning when failing to parse bday field

There is no much we can't do if other clients didn't respect the vCard spec.
Comment 2 Guillaume Desmottes 2012-04-30 13:25:11 UTC
Merged to 0.6.

Attachment 213102 [details] pushed as bdc430c - Raise a debug message rather than a warning when failing to parse bday field
Comment 3 Philip Withnall 2012-04-30 13:33:48 UTC
*** Bug 663177 has been marked as a duplicate of this bug. ***