After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675078 - Activities overview loses focus after results from gnome-documents are shown
Activities overview loses focus after results from gnome-documents are shown
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-29 14:36 UTC by maxx
Modified: 2012-04-29 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
searchDisplay: Reset the keyboard focus after displaying async results (1.61 KB, patch)
2012-04-29 22:37 UTC, Rui Matos
committed Details | Review

Description maxx 2012-04-29 14:36:48 UTC
1) Go to the Activities overview
2) Type in a search
3) Quickly (before the results from gnome-documents start ticking in) press the down arrow as if you were navigating to an app
4) When the results from gnome-documents now show up the focus disappears from the activity overview and it is no longer possible to navigate using the arrow keys

This is with gnome-shell-3.4.1.
Comment 1 Rui Matos 2012-04-29 22:37:22 UTC
Created attachment 213070 [details] [review]
searchDisplay: Reset the keyboard focus after displaying async results

We hide the content around displaying new search results to prevent
flickering, unfortunately, one side effect of hiding an actor is
losing key focus if it currently is on the that actor or any
child. This could happen in the case of async results showing up after
the user had moved focus to the search results.

This patch works around that issue by saving the key focus and
resetting it back after displaying the new async results.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-04-29 22:48:58 UTC
Review of attachment 213070 [details] [review]:

Shouldn't we only set the key focus if we contain it? Not that it really matters, of course. A simple comment would also be nice.
Comment 3 Rui Matos 2012-04-29 23:13:15 UTC
Pushed with a comment and a condition to set the focus back only if we
have it.

Attachment 213070 [details] pushed as 54788d7 - searchDisplay: Reset the keyboard focus after displaying async results