GNOME Bugzilla – Bug 675005
rename 'Logout' keybinding to 'Power Off'
Last modified: 2019-03-20 10:59:42 UTC
C-A-Del brings up a dialog with the title 'Power Off' which only offers shutdown/restart, not logout. Therefore, the keybinding should be renamed to 'Power Off'. We may want to add another keybinding to bring up the logout dialog. https://bugzilla.redhat.com//show_bug.cgi?id=814704
Hmm, Ctrl+Alt+Delete brings up the Log Out prompt here with gnome-control-center 3.6.3 on Ubuntu 13.04.
The way I read the gnome-settings-daemon code, it calls the org.gnome.SessionManager.Shutdown method when C-A-Del is hit. Maybe Ubuntu patches gnome-session to do something else ? In any case, this bug belongs to gsd
*** Bug 693501 has been marked as a duplicate of this bug. ***
I'll punt to the designers. The questions would be: - We don't have a keyboard shortcut for "shutdown" (same dialogue as the "Power Off" menu item in the shell), should we have one? - Should that shutdown keyboard shortcut be triggered with Ctrl+Alt+Delete by default, instead of it triggering logout? - What would the default keybinding be for "logout" if we changed it? - Or should we simply replace the logout shortcut, and have only the shutdown shortcut?
hmm, looks like we didn't attract any designer attention here
Historically ctrl+alt+del was used in Windows when things went south and you needed to reboot. There was also the "shoot yourself in the foot" Ctrl+Alt+Backspace to take X down. However we bind system level actions to <Super>. My suggestion would be to bind Log Out to <Super>+Delete and Power off to <Ctrl>+<Super>+Delete.
(In reply to comment #6) ... > However we bind system level actions to <Super>. My suggestion would be to bind > Log Out to <Super>+Delete and Power off to <Ctrl>+<Super>+Delete. Those seem like reasonable shortcuts, although I do wonder whether we want to enable these by default. There is a slight chance that someone could accidentally trigger one of them, then walk away from their machine and find it turned off. A shortcut that could cause data loss is something to be wary of.
Well I presume it would pop up the same dialog that the normal options do... you could just disable the "turn off automatically in 60 seconds" bit if that's a significant concern.
Bug still present in GNOME 3.20. Can this bug be used for the (apparently simple?) immediate fix of renaming "Log out" to "Shut down..." (or similar), so that the currently bound action is at least not incorrectly labelled? Then a separate bug can be opened for the question of having a shortcut for showing the logout menu, choosing the default binding, etc.
(In reply to Stephen from comment #9) > Bug still present in GNOME 3.20. > > Can this bug be used for the (apparently simple?) immediate fix of renaming > "Log out" to "Shut down..." (or similar), so that the currently bound action > is at least not incorrectly labelled? Note the shortcut is broken in more ways than one right now: it opens the power off menu *twice*
Yep, that seems to be a regression in 3.20 - 3.18 doesn't have that problem. Separate bug ;)
Please can this keyboard shortcut have its name fixed to Power Off? And a 2nd shortcut be added that _actually_ calls Log Out? The bug Michael noted is still present and, according to this ticket - https://bugzilla.gnome.org/show_bug.cgi?id=728151 - breaks keynav ability of the resulting (delayed, duplicated) dialog for certain subsets of users.
(In reply to Stephen from comment #9) > Bug still present in GNOME 3.20. > > Can this bug be used for the (apparently simple?) immediate fix of renaming > "Log out" to "Shut down..." (or similar), so that the currently bound action > is at least not incorrectly labelled? Yup, that's 100% the right thing to have done four years ago. Anything else can be proposed in another bug, another day.
(In reply to Michael Catanzaro from comment #13) > Yup, that's 100% the right thing to have done four years ago. Anything else > can be proposed in another bug, another day. Eh, maybe not, since this requires coordinated changes in gnome-control-center and gnome-settings-daemon to rename properly. It's clearly a g-s-d bug anyway; it provides a keybinding for log out, and does power off when received, which is just wrong. So let's fix it to do log out, and we can add a power off keybinding if designers can agree on what it should be.
Created attachment 335731 [details] [review] Fix logout media key Currently the logout key triggers the power off dialog. That's wrong. Don't commit this patch because it is itself broken. Here g_dbus_proxy_call_sync returns a NULL GVariant without setting error, but the function is documented to return a nonnull GVariant on success, and obviously error must be set on error.
(In reply to Michael Catanzaro from comment #13) > (In reply to Stephen from comment #9) > > Bug still present in GNOME 3.20. > > > > Can this bug be used for the (apparently simple?) immediate fix of renaming > > "Log out" to "Shut down..." (or similar), so that the currently bound action > > is at least not incorrectly labelled? > > Yup, that's 100% the right thing to have done four years ago. Anything else > can be proposed in another bug, another day. So, until the keybinding can be split and its real function implemented, I presume you still need a patch to fix its name? If so, I'll try to get that in.
No, a patch to fix the name would be required in several modules. What we don't want is a name change in gnome-control-center so it says "Power Off" but continues to call the log out API that actually powers off....
(In reply to Michael Catanzaro from comment #15) > Created attachment 335731 [details] [review] [review] > Fix logout media key > > Currently the logout key triggers the power off dialog. That's wrong. > > Don't commit this patch because it is itself broken. Here > g_dbus_proxy_call_sync returns a NULL GVariant without setting error, > but the function is documented to return a nonnull GVariant on success, > and obviously error must be set on error. So looks like there is a bug with GDBus :(
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/183.