GNOME Bugzilla – Bug 674925
Moving running input stream fails
Last modified: 2012-07-11 10:06:16 UTC
When changing the default input source, active recording streams are not moved. The attached patch will fix that, which will make input and output behaviour consistent. As a bonus, it will not destroy pulseaudio's input database when changing default sink anymore.
Created attachment 212939 [details] [review] Patch for Moving running input streams correctly
Review of attachment 212939 [details] [review]: This is racy actually. You shoud use separate new_default_stream variables (new_default_sink_stream and new_default_source_stream), and separate callbacks (even if they just end up calling gvc_mixer_control_stream_restore_cb() with a "is_sink" flag). Also, remove the "BugLink:", just the URL is enough, and remove the Signed-off-by, it's not used in GNOME.
Created attachment 217223 [details] [review] sound: Move running input streams when default source is changed When changing the default input source, active recording streams are not moved. This patch will fix that, which will make input and output behaviour consistent. As a bonus, it will not destroy pulseaudio's input database when changing default sink anymore.
Review of attachment 217223 [details] [review]: Hmm, I think you're correct about the race. (The set_default_sink is more likely to race with itself than with set_default_source, but in that case, it isn't a problem.) However in this version the filtering is gone, which means that it will still destroy the database for other side.
Created attachment 217412 [details] [review] Patch for Moving running input streams correctly This is Bastien's version of the patch but with added filtering.
(In reply to comment #5) > Created an attachment (id=217412) [details] [review] > Patch for Moving running input streams correctly > > This is Bastien's version of the patch but with added filtering. I can't see where you're doing that. I can't see a difference between the 2 patches.
Created attachment 217413 [details] [review] Patch for Moving running input streams correctly Sorry. This one should be better.
Created attachment 217414 [details] [review] Patch for Moving running input streams correctly Forgot to run "git format-patch" after committing, so uploaded the old patch again. Argh!
Attachment 217223 [details] pushed as fe69f4f - sound: Move running input streams when default source is changed
Created attachment 218525 [details] [review] Fix segfault This seems to be a persistent one. The previous patch introduced a segfault, please apply the attached patch to fix it.
Comment on attachment 218525 [details] [review] Fix segfault Minus the first hunk