After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674890 - [PATCH] Fix the colord support in GtkPrinterCups when the PPD is loaded async
[PATCH] Fix the colord support in GtkPrinterCups when the PPD is loaded async
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-26 16:22 UTC by Richard Hughes
Modified: 2012-04-30 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test patch, works for me (1.58 KB, patch)
2012-04-26 16:22 UTC, Richard Hughes 		none Details | Review
Fix the colord support in GtkPrinterCups when the PPD is loaded async (1.62 KB, patch)
2012-04-30 10:21 UTC, Matthias Clasen 		committed Details | Review

Description Richard Hughes 2012-04-26 16:22:07 UTC 
Created attachment 212897 [details] [review]
test patch, works for me

After testing 3.4.0 the colord integration seems to be broken. It seems now the PPD is loaded async, or perhaps there was a race in the existing code that seems to be triggered. Using GNOME 3.4 no color profiles are shown to the user and the color profile is always marked as "Unavailable" (although they are still used). This seems to be a recent regression. The attached patch fixes the problem by refreshing the printer when details-acquired is fired, which seems an obviously correct thing to do.

Please review. Thanks.
Comment 1 Matthias Clasen 2012-04-30 10:21:40 UTC 
The following fix has been pushed:
bf71b88 Fix the colord support in GtkPrinterCups when the PPD is loaded async
Comment 2 Matthias Clasen 2012-04-30 10:21:43 UTC 
Created attachment 213085 [details] [review]
Fix the colord support in GtkPrinterCups when the PPD is loaded async

If the PPD is not available when the printer is loaded then the PPD options are
not available and we can't get the correct qualifier to use with colord.

When the PPD becomes available, refresh the profile title to reflect reality.