GNOME Bugzilla – Bug 674844
lang files for MXML and actionscript
Last modified: 2012-08-07 21:25:49 UTC
Created attachment 212847 [details] syntax files for mxml and actionscript Please see attached syntax files for MXML(flex) and actionscript. MXML can have blocks of css actionscript and xml similar to xhtml. Original version taken from http://www.conic.se/blog/posts/8/ I've added support to <fx:Script> block in addition to <mx:Script> by replacing the following lines: --<start><mx:Script></start> --<end></mx:Script></end> with: ++<start><(fx:Script|mx:Script)></start> ++<end></\%{1@start}></end> Thanks
Created attachment 213514 [details] [review] actionscript.lang
Created attachment 213515 [details] [review] mxml.lang
Created attachment 213519 [details] [review] actionscript.lang
Created attachment 213520 [details] [review] maxml.lang
Created attachment 213522 [details] [review] include actionscript.lang and mxml.lang
Created attachment 219787 [details] [review] Actionscript lang file
Review of attachment 213522 [details] [review]: the files should also be added to Makefile.am
Review of attachment 213520 [details] [review]: ::: data/language-specs/mxml.lang @@ +4,3 @@ + This file is part of GtkSourceView + + Authors: Marco Barisione, Emanuele Aina, Paolo Borelli, Markus Johnsson Authors are wrong here... I am pretty sure me, Marco and Emanuale did not write this @@ +27,3 @@ +<language id="mxml" _name="MXML" version="2.0" _section="Markup"> + <metadata> + <property name="mimetypes">application/mxml;text/mxml</property> why two mime types? are these mime types officially included in freedesktop's shared-mime-info database? @@ +61,3 @@ + </context> + + <context id="unallowed-chars" style-ref="error" extend-parent="false"> Why is this file duplicating much of xml.lang? it should either extend xml.lang if it is an xml syntax (see e.g. docbook.lang for an example) or should at least include xml's contexts instead of duplicating them
Review of attachment 219787 [details] [review]: ::: data/language-specs/actionscript.lang @@ +25,3 @@ +<language id="actionscript" _name="ActionScript" version="2.0" _section="Sources"> + <metadata> + <property name="mimetypes">text/x-actionscript</property> indentation must be 2 spaces @@ +50,3 @@ + <definitions> + + <context id="string" style-ref="string" end-at-line-end="true"> indentation must be 2 spaces @@ +223,3 @@ + + <context id="future-reserved-words" style-ref="reserved"> + <keyword>goto</keyword> ditto
Created attachment 220603 [details] [review] mxml language file
Created attachment 220604 [details] [review] Actionscript lang file
Created attachment 220605 [details] [review] POTFILES.in
Created attachment 220606 [details] [review] Makefile.am
Created attachment 220607 [details] [review] mxml.lang
thanks for updating the lang files. I committed everythingThis problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.