GNOME Bugzilla – Bug 674805
gdbusproxy async test is broken
Last modified: 2017-12-13 14:00:21 UTC
The gdbusproxy async test creates a proxy asynchronously and then immediately returns. The test framework then takes down the connection, so the async test's callback may never be called. If it is called, it can fail because it expects no error, while an error is set because the connection has since been closed by the test framework. If I modify the test to start a main loop, it then fails because some of the property tests fail because a previous test modified the value of the properties. I talked with davidz on irc, and he feels that the test is broken because it relies on the gdbusproxy test setting up the server, and tests should be able to run in any order and independently of other tests.
Yup, we should fix that. Thanks for opening the bug.
Created attachment 212914 [details] [review] Patch.
*** Bug 675088 has been marked as a duplicate of this bug. ***
*** Bug 672248 has been marked as a duplicate of this bug. ***
Could Mike get a response to his patch, please?
The patch has actually been committed for some time. I may have pushed it by accident in the course of pushing one of my patches for bug 652650.
Review of attachment 212914 [details] [review]: (In reply to Mike Gorse from comment #6) > The patch has actually been committed for some time. I may have pushed it by > accident in the course of pushing one of my patches for bug 652650. Indeed, it was pushed as 375943ea215871c0fe6d1d02e970cb2d71c8445c. Nobody seems to have objected in the intervening years, so let’s consider this reviewed and accepted.