After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674703 - several memory leaks
several memory leaks
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-24 10:00 UTC by Pavel Vasin
Modified: 2012-04-24 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-mouse-fix-mem-leak.patch (1.13 KB, patch)
2012-04-24 10:01 UTC, Pavel Vasin
committed Details | Review
0002-mouse-fix-mem-leak.patch (1.24 KB, patch)
2012-04-24 10:01 UTC, Pavel Vasin
needs-work Details | Review
0003-housekeeping-fix-GList-leak.patch (1004 bytes, patch)
2012-04-24 10:02 UTC, Pavel Vasin
committed Details | Review
patch 2 (1.31 KB, patch)
2012-04-24 10:38 UTC, Pavel Vasin
committed Details | Review

Description Pavel Vasin 2012-04-24 10:00:39 UTC
I found several memory leaks by using the valgrind.
Comment 1 Pavel Vasin 2012-04-24 10:01:34 UTC
Created attachment 212671 [details] [review]
0001-mouse-fix-mem-leak.patch
Comment 2 Pavel Vasin 2012-04-24 10:01:53 UTC
Created attachment 212672 [details] [review]
0002-mouse-fix-mem-leak.patch
Comment 3 Pavel Vasin 2012-04-24 10:02:13 UTC
Created attachment 212673 [details] [review]
0003-housekeeping-fix-GList-leak.patch
Comment 4 Bastien Nocera 2012-04-24 10:11:39 UTC
Review of attachment 212671 [details] [review]:

Looks correct
Comment 5 Bastien Nocera 2012-04-24 10:17:06 UTC
Review of attachment 212672 [details] [review]:

::: plugins/mouse/gsd-mouse-manager.c
@@ +519,3 @@
+have_program_in_path (const char *name)
+{
+        gchar *path = g_find_program_in_path (name);

Split this in 2 lines please.

@@ +521,3 @@
+        gchar *path = g_find_program_in_path (name);
+        g_free (path);
+        return path != NULL;

I'd rather you stored the retval as a boolean rather than rely on a freed pointer.
Comment 6 Bastien Nocera 2012-04-24 10:18:25 UTC
Review of attachment 212673 [details] [review]:

Looks correct
Comment 7 Pavel Vasin 2012-04-24 10:38:30 UTC
Created attachment 212683 [details] [review]
patch 2
Comment 8 Pavel Vasin 2012-04-24 13:40:35 UTC
That's all. Please commit.