GNOME Bugzilla – Bug 674703
several memory leaks
Last modified: 2012-04-24 13:56:48 UTC
I found several memory leaks by using the valgrind.
Created attachment 212671 [details] [review] 0001-mouse-fix-mem-leak.patch
Created attachment 212672 [details] [review] 0002-mouse-fix-mem-leak.patch
Created attachment 212673 [details] [review] 0003-housekeeping-fix-GList-leak.patch
Review of attachment 212671 [details] [review]: Looks correct
Review of attachment 212672 [details] [review]: ::: plugins/mouse/gsd-mouse-manager.c @@ +519,3 @@ +have_program_in_path (const char *name) +{ + gchar *path = g_find_program_in_path (name); Split this in 2 lines please. @@ +521,3 @@ + gchar *path = g_find_program_in_path (name); + g_free (path); + return path != NULL; I'd rather you stored the retval as a boolean rather than rely on a freed pointer.
Review of attachment 212673 [details] [review]: Looks correct
Created attachment 212683 [details] [review] patch 2
That's all. Please commit.