After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674674 - right click does nothing
right click does nothing
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-23 23:49 UTC by William Jon McCann
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
collection: Enter selection mode on right-click (1.52 KB, patch)
2012-10-23 23:48 UTC, Zeeshan Ali 		reviewed Details | Review
collection: Enter selection mode on right-click (1.70 KB, patch)
2012-10-24 20:28 UTC, Zeeshan Ali 		committed Details | Review

Description William Jon McCann 2012-04-23 23:49:20 UTC 
It is a bit odd that right click does nothing in the boxes overview.

We should probably be consistent with what Documents does.

There are really two options. One is to so the same as left click and the other is what boxes is doing and shortcut to the selection mode.
Comment 1 Zeeshan Ali 2012-10-23 23:48:54 UTC 
Created attachment 227109 [details] [review]
collection: Enter selection mode on right-click

Lets handle right click the same way as Documents does: If there is a
box under the cursor, enter selection mode and select the box.

Note: Unlike Documents, we are not resetting selection when exiting
selection mode and this patch makes this bug even more annoying so that
should be the next thing to fix.
Comment 2 Christophe Fergeau 2012-10-24 08:37:23 UTC 
Review of attachment 227109 [details] [review]:

Looks good

::: src/collection-view.vala
@@ +402,1 @@
             return false;

This test can be moved before  
if (path != null)
  button_press_item_path = path.to_string ();
and then the "if (path != null)" test can be removed.
Comment 3 Zeeshan Ali 2012-10-24 20:28:13 UTC 
Created attachment 227193 [details] [review]
collection: Enter selection mode on right-click

Lets handle right click the same way as Documents does: If there is a
box under the cursor, enter selection mode and select the box.

Note: Unlike Documents, we are not resetting selection when exiting
selection mode and this patch makes this bug even more annoying so that
should be the next thing to fix.
Comment 4 Zeeshan Ali 2012-10-25 13:16:52 UTC 
Attachment 227193 [details] pushed as 0fab363 - collection: Enter selection mode on right-click