GNOME Bugzilla – Bug 674671
selection mode doesn't match mockup
Last modified: 2016-03-31 13:58:17 UTC
Created attachment 212641 [details] screenshot The selection mode doesn't match the mockups. The toolbar in selection mode is supposed to be a different color. The label at the top should not be in italics. And I think we want the button to be "Done" not Cancel.
It would be nice to have a link to the latest version of the mockup (/me searching)
https://github.com/gnome-design-team/gnome-mockups/blob/master/boxes/boxes-selection (incorrect mime-type, need to open manually)
Sorry for the wrong filename. Should be https://github.com/gnome-design-team/gnome-mockups/blob/master/boxes/boxes-selection.png
Created attachment 225206 [details] [review] Use the right style classes for selection mode.
Created attachment 225207 [details] [review] Rename selection mode button to "Done" This is how the mockups and gnome-documents does it.
These two patches should do it, however there are issues: 1) The selection-mode toolbar doesn't look right in dark mode. Will upload example screenshot 2) Cancel -> Done is a string change.
Created attachment 225208 [details] Non-selection mode (for comparison)
Created attachment 225209 [details] Selection mode in dark, looks wrong.
(Whats wrong: no line under the toolbar in selection mode)
Also, we should add the menu button that gnome-documents has in its selection toolbar, so that we're in sync with the design of gnome-docs.
Created attachment 225475 [details] [review] Add line between topbar and icon view This adds a line between the top bar and the icon view, similar to what gnome-documents does it. In fact, it uses the same style class documents-scrolledwin that GdMainView uses for this, which we don't get due to not using GdMainView. In the normal case this doesn't really chang anything in boxes, however in selection mode we need this line in order to separate the toolbar from the icon view as they have the same color there.
Review of attachment 225207 [details] [review]: ACK, but we are still string frozen.
Review of attachment 225206 [details] [review]: I don't really see a difference with/without these classes, but I assume this is doing the same as GNOME Documents? Longer term, it would be nice if this logic could move into libgd..
Review of attachment 225475 [details] [review]: In the log "chang" -> "change" This is also something that I'd rather be done "elsewhere", but I'm fine with having this in Boxes for now.
Attachment 225206 [details] pushed as 43832a8 - Use the right style classes for selection mode. Attachment 225475 [details] pushed as 720f82c - Add line between topbar and icon view
Attachment 225207 [details] pushed as f755c75 - Rename selection mode button to "Done"