After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674543 - Heal tool reads garbage values from solution matrix
Heal tool reads garbage values from solution matrix
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.8.0-RC1
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-21 20:44 UTC by Mike Henning (drawoc)
Modified: 2013-12-08 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch. (872 bytes, patch)
2012-04-21 20:44 UTC, Mike Henning (drawoc) 		none Details | Review

Description Mike Henning (drawoc) 2012-04-21 20:44:21 UTC 
Created attachment 212523 [details] [review]
Patch.

In the heal tool, the black checkers of the left hand edge of the solution matrix aren't currently being assigned a value.

Attached is a (trivial) patch that solves the issue.

It might explain the corruption described here (although I was never really able to reproduce the issue): https://mail.gnome.org/archives/gimp-developer-list/2012-April/msg00122.html

Also, it seems that this fixes the corruption in the proposed patch for bug 568098. (That patch is attachment 184900 [details] [review]).
Comment 1 Alexia Death 2012-04-24 19:13:42 UTC 
Tested, confirmed and committed.

commit 2920344524aa358c589897c39b0438cc99817b04
Author: Michael Henning <mikehenning@eclipse.net>
Date:   Sat Apr 21 15:59:42 2012 -0400

    app: Prevent uninitialized values in the heal tool.
    
    Previously, the black checkers of the left hand edge of the solution
    matrix were not being assigned a value.